Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): update lane change status in planWaitingApproval() #3061

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 13, 2023

Description

Previously, the updateLaneChnageStatus() is called in onEntry() at once, and is never called again in new manager.
In this PR, I added updateLaneChnageStatus() to planWaitingApproval() in order to update status_ every planning cycle.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (d8c826c) 11.95% compared to head (fe3edca) 11.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3061      +/-   ##
==========================================
- Coverage   11.95%   11.87%   -0.08%     
==========================================
  Files        1324     1324              
  Lines       92113    92707     +594     
  Branches    24625    25044     +419     
==========================================
+ Hits        11012    11013       +1     
- Misses      69686    70244     +558     
- Partials    11415    11450      +35     
Flag Coverage Δ *Carryforward flag
differential 5.55% <0.00%> (?)
total 11.95% <ø> (ø) Carriedforward from d8c826c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit e6615b3 into autowarefoundation:main Mar 13, 2023
@satoshi-ota satoshi-ota deleted the fix/update-lane-change-status-in-waiting-approval branch March 13, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants