refactor(lane change): lane change class rework

[zulfaqar-azmi-t4]

Description

refactor lane change class so that it is more resemble to scene module manager

⬇️ This launcher needs to be merge first
autowarefoundation/autoware_launch#248

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (be0929b) 11.86% compared to head (7b320b4) 11.84%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   11.86%   11.84%   -0.03%     
==========================================
  Files        1333     1333              
  Lines       92801    92960     +159     
  Branches    24660    24756      +96     
==========================================
  Hits        11014    11014              
- Misses      70372    70528     +156     
- Partials    11415    11418       +3     

Flag	Coverage Δ		*Carryforward flag
differential	5.25% <0.00%> (?)
total	11.87% <ø> (+<0.01%)	⬆️	Carriedforward from a0f4309

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...er/scene_module/lane_change/lane_change_module.hpp	0.00% <ø> (ø)
...anner/util/lane_change/lane_change_module_data.hpp	0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp	0.13% <0.00%> (-0.01%)	⬇️
...rc/scene_module/lane_change/lane_change_module.cpp	0.00% <0.00%> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp	0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp	11.41% <0.00%> (-0.08%)	⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[satoshi-ota]

I think we have to update this line, lane_change_right || lane_change_left.

autoware.universe/planning/behavior_path_planner/src/planner_manager.cpp

Line 284 in 0d4e444

if (name == "lane_change") {

[zulfaqar-azmi-t4]

Evaluator test when using New framework seems good (No degradation)
https://github.com/tier4/pilot-auto/commit/cc281caf6a6d0dc7a95f6bd92aa5e95a84984f1e

Evaluator test when using Old framework (No degration)
https://evaluation.tier4.jp/evaluation/reports/3f1b7141-f745-5b6f-8b8a-173196f1ee7d?project_id=prd_jt

[satoshi-ota]

@zulfaqar-azmi-t4 LGTM 👍 I'll approve it after you resolve conflicts.