Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): use previous output #3059

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 12, 2023

Description

add new lane change utils function to generate prepare segment from previous module output.

PathWithLaneId getLaneChangePathPrepareSegment(
  const PathWithLaneId & original_path, const lanelet::ConstLanelets & original_lanelets,
  const Pose & current_pose, const double backward_path_length, const double prepare_distance,
  const double prepare_speed);

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (0056a2a) 11.94% compared to head (9acc03c) 11.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
- Coverage   11.94%   11.93%   -0.01%     
==========================================
  Files        1326     1326              
  Lines       92209    92219      +10     
  Branches    24649    24654       +5     
==========================================
  Hits        11010    11010              
- Misses      69785    69795      +10     
  Partials    11414    11414              
Flag Coverage Δ *Carryforward flag
differential 5.54% <0.00%> (?)
total 11.94% <ø> (+<0.01%) ⬆️ Carriedforward from 0056a2a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <ø> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota force-pushed the fix/use-previous-module-output-lane-change-util branch from cbbd76e to 9acc03c Compare March 13, 2023 02:06
@satoshi-ota satoshi-ota marked this pull request as ready for review March 13, 2023 04:16
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and there's no issue.
LGTM

@satoshi-ota satoshi-ota merged commit 969dacf into autowarefoundation:main Mar 13, 2023
@satoshi-ota satoshi-ota deleted the fix/use-previous-module-output-lane-change-util branch March 13, 2023 06:38
xianglunkai pushed a commit to xianglunkai/autoware.universe that referenced this pull request Apr 3, 2023
Signed-off-by: GitHub <noreply@github.com>

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants