Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): refactored occupancy_grid_map launcher #3058

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Mar 11, 2023

Description

This PR depends on #3032.

Enable to user to switch pointcloud-based and laserscan-based method in single argument.

  • before
    • perception.launch.xml -> pointcloud/laserscan launch.py
  • after
    • perception.launch.xml -> probablistic_occuapcy_grid_map.launch.xml -> pointcloud/laserscan launch.py

This results in shorter descriptions and method change in minimum fixes.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 11, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2a23a4b) 11.92% compared to head (042945d) 11.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3058      +/-   ##
==========================================
- Coverage   11.92%   11.91%   -0.01%     
==========================================
  Files        1334     1334              
  Lines       92928    92928              
  Branches    24729    24729              
==========================================
- Hits        11078    11076       -2     
- Misses      70370    70371       +1     
- Partials    11480    11481       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.93% <ø> (+0.01%) ⬆️ Carriedforward from 2f32826

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

add scan_frame and raytrace center

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi force-pushed the feature/switch_occupancy_gridmap_launcher branch from ac6fdb7 to 467c89b Compare March 16, 2023 17:59
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Mar 16, 2023
and fix missing }

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi force-pushed the feature/switch_occupancy_gridmap_launcher branch from 73dab25 to 7095da9 Compare March 16, 2023 18:25
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi marked this pull request as ready for review March 17, 2023 05:17
@YoshiRi YoshiRi requested review from yukkysaito, a team and miursh as code owners March 17, 2023 05:17
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 17, 2023
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants