Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): use previous module output #3043

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 10, 2023

Description

use previous module output in new manager

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 10, 2023
@satoshi-ota
Copy link
Contributor Author

satoshi-ota commented Mar 10, 2023

NOTE: This PR use util function that is added in #3042, so there are two commits to removed before merge.

-> Already removed.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e92be64) 11.94% compared to head (19c7993) 11.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3043      +/-   ##
==========================================
- Coverage   11.94%   11.94%   -0.01%     
==========================================
  Files        1326     1326              
  Lines       92190    92209      +19     
  Branches    24639    24649      +10     
==========================================
  Hits        11013    11013              
- Misses      69765    69784      +19     
  Partials    11412    11412              
Flag Coverage Δ *Carryforward flag
differential 5.55% <0.00%> (?)
total 11.94% <ø> (+<0.01%) ⬆️ Carriedforward from e92be64

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 23.80% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <ø> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 7.58% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the fix/use-previous-module-output-avoidance branch from a24ddc0 to 19c7993 Compare March 11, 2023 04:49
@zulfaqar-azmi-t4
Copy link
Contributor

Seems to be no issue.

cap-.2023-03-13-13-53-32.mp4.mp4

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 5ca8e68 into autowarefoundation:main Mar 13, 2023
@satoshi-ota satoshi-ota deleted the fix/use-previous-module-output-avoidance branch March 13, 2023 06:42
@satoshi-ota
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants