fix(crop_box_filter): fix bug

[sykwer]

Description

Fix bug in #2908.
Resolve #2970.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[yukkysaito]

LGTM

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (f9075cb) 12.81% compared to head (e5288eb) 12.79%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
- Coverage   12.81%   12.79%   -0.02%     
==========================================
  Files        1212     1212              
  Lines       85613    85714     +101     
  Branches    24260    24260              
==========================================
  Hits        10968    10968              
- Misses      63282    63383     +101     
  Partials    11363    11363              

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	12.81% <ø> (+<0.01%)	⬆️	Carriedforward from 4c98689

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp	0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp	0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp	0.15% <ø> (ø)
...or/src/crop_box_filter/crop_box_filter_nodelet.cpp	0.00% <0.00%> (ø)
...entation/include/ground_segmentation/gencolors.hpp	0.00% <0.00%> (ø)
...ssor/src/passthrough_filter/passthrough_uint16.cpp	0.00% <0.00%> (ø)
...rocessor/passthrough_filter/passthrough_uint16.hpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[VRichardJP]

Although it is not related to the bug, I think there is another problem with the implementation: the last point of the point cloud is ignored:

autoware.universe/sensing/pointcloud_preprocessor/src/crop_box_filter/crop_box_filter_nodelet.cpp

Lines 125 to 126 in 4c98689

	for (size_t global_offset = 0; global_offset + input->point_step < input->data.size();
	global_offset += input->point_step) {

Let's take a simple example: input cloud is 1D and has 1 point. Then:

• input->point_step = 1
• input->data.size() = 1
  So when the loop starts (global_offset = 0), the clause global_offset + input->point_step < input->data.size() is false and we immediately leave the loop, ignoring the first (last) point.

Could you fix that as well?