Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fault injection): add find package to cmake #2973

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Mar 1, 2023

Description

I fixed build error of fault injection.

--- stderr: fault_injection
CMake Error at /opt/ros/humble/share/ament_cmake_auto/cmake/ament_auto_add_library.cmake:66 (add_library):
  Target "fault_injection_node_component" links to target
  "pluginlib::pluginlib" but the target was not found.  Perhaps a
  find_package() call is missing for an IMPORTED target, or an ALIAS target
  is missing?
Call Stack (most recent call first):
  CMakeLists.txt:7 (ament_auto_add_library)
CMake Error at /opt/ros/humble/share/ament_cmake_auto/cmake/ament_auto_add_library.cmake:66 (add_library):
  Target "fault_injection_node_component" links to target
  "pluginlib::pluginlib" but the target was not found.  Perhaps a
  find_package() call is missing for an IMPORTED target, or an ALIAS target
  is missing?
Call Stack (most recent call first):
  CMakeLists.txt:7 (ament_auto_add_library)
CMake Generate step failed.  Build files cannot be regenerated correctly.
---
Failed   <<< fault_injection [1min 12s, exited with code 1]

(I don't understand why fault_injection depends on pluginlib package.
There are many other packages to register plugins by rclcpp_components_register_node, but any other module without fault_injection do not cause error. )

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested review from KeisukeShima and a team as code owners March 1, 2023 09:13
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f75c7d) 11.98% compared to head (ef21e89) 11.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   11.98%   11.98%           
=======================================
  Files        1318     1318           
  Lines       91506    91504    -2     
  Branches    24240    24240           
=======================================
  Hits        10970    10970           
+ Misses      69174    69172    -2     
  Partials    11362    11362           
Flag Coverage Δ *Carryforward flag
differential 41.17% <ø> (?)
total 11.98% <ø> (+<0.01%) ⬆️ Carriedforward from 5792c47

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wep21
Copy link
Contributor

wep21 commented Mar 1, 2023

Is it better to add pluginlib dependency into package.xml?

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4
Copy link
Contributor Author

tkimura4 commented Mar 1, 2023

@wep21
Thanks. I added it!

@wep21 wep21 changed the title fix(fault injection) add find package to cmake fix(fault injection): add find package to cmake Mar 1, 2023
Copy link
Contributor

@KeisukeShima KeisukeShima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tkimura4 tkimura4 merged commit a2c62dc into autowarefoundation:main Mar 1, 2023
@tkimura4 tkimura4 deleted the fix/fault_injection_build branch March 1, 2023 13:36
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Mar 2, 2023
)

* fix(fault injection) add find package to cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add pluginlib to dependency

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Mar 2, 2023
) (#297)

* fix(fault injection) add find package to cmake



* feat: add pluginlib to dependency



---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
s-azumi pushed a commit to tier4/autoware.universe that referenced this pull request Mar 2, 2023
)

* fix(fault injection) add find package to cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add pluginlib to dependency

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
s-azumi pushed a commit to tier4/autoware.universe that referenced this pull request Mar 2, 2023
)

* fix(fault injection) add find package to cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add pluginlib to dependency

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
s-azumi added a commit to tier4/autoware.universe that referenced this pull request Mar 2, 2023
) (#298)

* fix(fault injection) add find package to cmake



* feat: add pluginlib to dependency



---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Mar 3, 2023
) (#297)

* fix(fault injection) add find package to cmake



* feat: add pluginlib to dependency



---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
)

* fix(fault injection) add find package to cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add pluginlib to dependency

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 7, 2023
)

* fix(fault injection) add find package to cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add pluginlib to dependency

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
shmpwk pushed a commit that referenced this pull request Mar 7, 2023
* fix(fault injection) add find package to cmake

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add pluginlib to dependency

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
shmpwk added a commit to shmpwk/autoware that referenced this pull request Mar 7, 2023
taikitanaka3 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 15, 2023
) (#298)

* fix(fault injection) add find package to cmake



* feat: add pluginlib to dependency



---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants