Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): move findEgoIndex & findEgoSegmentIndex to planner data #2912

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 20, 2023

Description

move duplicated function (findEgoIndex, findEgoSegmentIndex) to planner data

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 20, 2023
…o planner data

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 11.79% // Head: 11.72% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (f6fafa1) compared to base (e161141).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   11.79%   11.72%   -0.07%     
==========================================
  Files        1322     1328       +6     
  Lines       92793    93340     +547     
  Branches    24997    25245     +248     
==========================================
  Hits        10945    10945              
- Misses      70375    70922     +547     
  Partials    11473    11473              
Flag Coverage Δ *Carryforward flag
differential 6.16% <0.00%> (?)
total 11.79% <ø> (+<0.01%) ⬆️ Carriedforward from e161141

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.31% <ø> (+<0.01%) ⬆️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <0.00%> (ø)
.../include/behavior_path_planner/debug_utilities.hpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <0.00%> (ø)
...r/scene_module/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...er/scene_module/lane_change/lane_change_module.hpp 0.00% <ø> (ø)
...anner/scene_module/pull_out/geometric_pull_out.hpp 0.00% <ø> (ø)
..._planner/scene_module/pull_out/pull_out_module.hpp 0.00% <ø> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit 51ffc39 into autowarefoundation:main Feb 20, 2023
@satoshi-ota satoshi-ota deleted the fix/move-find-ego-index branch February 20, 2023 08:37
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…o planner data (autowarefoundation#2912)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…o planner data (autowarefoundation#2912)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
xianglunkai pushed a commit to xianglunkai/autoware.universe that referenced this pull request Apr 3, 2023
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants