Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix shift line merging logic #2882

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 14, 2023

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

Fix shift line merging logic. Before this PR, at start_idx and end_idx, the shift length is same value as start_idx - 1 and end_idx - 1 because the flag has_object is set true only between start_idx + 1 and end_idx - 1. Then, the total shift line may not include edge of the raw shift line.

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ca8e68) 11.86% compared to head (3f4a972) 11.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2882   +/-   ##
=======================================
  Coverage   11.86%   11.86%           
=======================================
  Files        1333     1333           
  Lines       92800    92800           
  Branches    24660    24660           
=======================================
  Hits        11012    11012           
  Misses      70372    70372           
  Partials    11416    11416           
Flag Coverage Δ *Carryforward flag
differential 5.54% <0.00%> (?)
total 11.86% <ø> (+<0.01%) ⬆️ Carriedforward from 5ca8e68

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the fix/shift-line-generation-logic branch from 91aba0f to 3f4a972 Compare March 13, 2023 09:08
@satoshi-ota satoshi-ota changed the title fix(avoidance): fix bug in shift line generation logic fix(avoidance): fix shift line merging logic Mar 13, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review March 13, 2023 23:44
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 1b4fa2b into autowarefoundation:main Mar 14, 2023
@satoshi-ota satoshi-ota deleted the fix/shift-line-generation-logic branch March 14, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants