Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix bug in calculation of rss longitudinal margin #2872

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 12, 2023

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

fix bug in calculation of rss longitudinal margin

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 11.70% // Head: 11.70% // No change to project coverage 👍

Coverage data is based on head (3c30a62) compared to base (fb2bb6d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2872   +/-   ##
=======================================
  Coverage   11.70%   11.70%           
=======================================
  Files        1314     1314           
  Lines       91601    91601           
  Branches    24478    24478           
=======================================
  Hits        10724    10724           
  Misses      69690    69690           
  Partials    11187    11187           
Flag Coverage Δ *Carryforward flag
differential 4.67% <0.00%> (?)
total 11.70% <ø> (+<0.01%) ⬆️ Carriedforward from fb2bb6d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota
Copy link
Contributor Author

@tkimura4 Thanks for your review 😄

@satoshi-ota satoshi-ota merged commit 5833067 into autowarefoundation:main Feb 14, 2023
@satoshi-ota satoshi-ota deleted the fix/rss-calculation-bug-avoidance branch February 14, 2023 22:41
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants