-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tier4_planning_rviz_plugin): create abstract class for footprint #2870
refactor(tier4_planning_rviz_plugin): create abstract class for footprint #2870
Conversation
Codecov ReportBase: 11.63% // Head: 11.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2870 +/- ##
==========================================
- Coverage 11.63% 11.62% -0.01%
==========================================
Files 1321 1322 +1
Lines 92199 92265 +66
Branches 24471 24471
==========================================
Hits 10726 10726
- Misses 70287 70353 +66
Partials 11186 11186
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…rint Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
86b0a07
to
01d490e
Compare
@yukkysaito Could you review the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7a259e7
to
67baad2
Compare
67baad2
to
af6a10a
Compare
Description
Footprint for path with lane id, path, trajectory is almost same implementation.
Therefore, I created an abstract class for them.
The only difference among the footprints is that path with lane id has
lane_id
visualization.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.