Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix drivable area expansion method outside intersection #2861

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 10, 2023

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

The drivable area expansion algorithm I modified should be applied not only to intersection but also outside the intersection as follows.

before
image

after
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…e intersection

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 10, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review February 10, 2023 08:06
@takayuki5168
Copy link
Contributor Author

@zulfaqar-azmi-t4 @purewater0901
Could you review the PR. psim worked well.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 11.63% // Head: 11.63% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5b8ec30) compared to base (95be33e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2861   +/-   ##
=======================================
  Coverage   11.63%   11.63%           
=======================================
  Files        1321     1321           
  Lines       92202    92200    -2     
  Branches    24472    24471    -1     
=======================================
  Hits        10727    10727           
+ Misses      70290    70288    -2     
  Partials    11185    11185           
Flag Coverage Δ *Carryforward flag
differential 4.67% <0.00%> (?)
total 11.63% <ø> (+<0.01%) ⬆️ Carriedforward from 95be33e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BEFORE
Screenshot from 2023-02-10 17-42-00

AFTER
Screenshot from 2023-02-10 17-40-36

@takayuki5168 takayuki5168 enabled auto-merge (squash) February 10, 2023 08:45
@takayuki5168 takayuki5168 merged commit d30616f into autowarefoundation:main Feb 10, 2023
@takayuki5168 takayuki5168 deleted the fix/drivable-area-expansion-except-for-intersection branch February 10, 2023 08:58
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Feb 13, 2023
…e intersection (autowarefoundation#2861)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants