Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add option to disable path update #2831

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 7, 2023

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

add option to disable path update

When the flag is set true
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@satoshi-ota Could you review the PR.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 11.61% // Head: 11.56% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (e8bb19c) compared to base (2a93ee3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2831      +/-   ##
==========================================
- Coverage   11.61%   11.56%   -0.06%     
==========================================
  Files        1319     1319              
  Lines       92107    92516     +409     
  Branches    24424    24701     +277     
==========================================
+ Hits        10701    10702       +1     
- Misses      70233    70557     +324     
- Partials    11173    11257      +84     
Flag Coverage Δ *Carryforward flag
differential 4.69% <0.00%> (?)
total 11.61% <0.00%> (ø) Carriedforward from 2a93ee3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/scene_module/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.25% <0.00%> (+0.09%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit ff9d064 into autowarefoundation:main Feb 9, 2023
@takayuki5168 takayuki5168 deleted the feat/disable-avoidance-path-update branch February 9, 2023 01:19
@TakaHoribe
Copy link
Contributor

@takayuki5168 Is this for the debugging purpose?

@takayuki5168
Copy link
Contributor Author

@TakaHoribe
Right for me. Or it can be used if someone wants to develop a path planning in the motion layer where the objects to avoid are decided in the behavior layer.

With the current motion planner, this flag is supposed to be set to false since the motion planner does not support stable avoidance the same as enable_bound_clipping, which extracts objects from the drivable area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants