Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): resample making empty path #2827

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Feb 7, 2023

Description

This is a fix for the issue of the process dying in the behavior_velocity_planner.

Related links

Tests performed

Checked in the planner won't die in the several map with an intersection, crosswalk traffic light scenes.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from rej55 and a team as code owners February 7, 2023 06:22
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 7, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe enabled auto-merge (squash) February 7, 2023 06:29
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 11.61% // Head: 11.61% // No change to project coverage 👍

Coverage data is based on head (e4ac67c) compared to base (cad63f7).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2827   +/-   ##
=======================================
  Coverage   11.61%   11.61%           
=======================================
  Files        1319     1319           
  Lines       92108    92108           
  Branches    24425    24425           
=======================================
  Hits        10699    10699           
  Misses      70237    70237           
  Partials    11172    11172           
Flag Coverage Δ *Carryforward flag
differential 3.42% <0.00%> (?)
total 11.61% <0.00%> (ø) Carriedforward from cad63f7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit a00e671 into autowarefoundation:main Feb 7, 2023
@TakaHoribe TakaHoribe deleted the fix/points-interval branch February 7, 2023 06:58
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants