fix(lane_following): remove lane change intersection check

[zulfaqar-azmi-t4]

Description

Previously this function is necessary because lane change could not be performed in the intersection.

Since such is not the case anymore, it might be better to remove it totally.

Related links

#2720

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 11.61% // Head: 11.59% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (155ae61) compared to base (2a93ee3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2826      +/-   ##
==========================================
- Coverage   11.61%   11.59%   -0.03%     
==========================================
  Files        1319     1319              
  Lines       92107    92303     +196     
  Branches    24424    24534     +110     
==========================================
  Hits        10701    10701              
- Misses      70233    70426     +193     
- Partials    11173    11176       +3     

Flag	Coverage Δ		*Carryforward flag
differential	4.72% <0.00%> (?)
total	11.61% <0.00%> (ø)		Carriedforward from 2a93ee3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp	23.80% <ø> (ø)
...ne_module/lane_following/lane_following_module.cpp	0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp	0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp	6.99% <ø> (-0.99%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rej55]

LGTM