Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(freespace_planning_algorithms): add nlohmann-json-dev dependency #2818

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 6, 2023

Description

Added dependency nlohmann-json3-dev, used in https://github.com/autowarefoundation/autoware.universe/blob/main/planning/freespace_planning_algorithms/src/rrtstar_core.cpp#L17

See autowarefoundation/autoware#3222

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 6, 2023
@esteve esteve enabled auto-merge (squash) February 6, 2023 10:52
@esteve esteve changed the title build(freespace_planning_algorithms): add nlohmann-json3-dev dependency build(freespace_planning_algorithms): add nlohmann-json-dev dependency Feb 6, 2023
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 11.61% // Head: 11.66% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (caa1166) compared to base (e91af6f).
Patch coverage: 7.31% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2818      +/-   ##
==========================================
+ Coverage   11.61%   11.66%   +0.04%     
==========================================
  Files        1319     1319              
  Lines       92105    92174      +69     
  Branches    24416    24461      +45     
==========================================
+ Hits        10700    10752      +52     
  Misses      70234    70234              
- Partials    11171    11188      +17     
Flag Coverage Δ *Carryforward flag
differential 61.55% <0.00%> (?)
total 11.61% <7.50%> (ø) Carriedforward from e91af6f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ocalization/ekf_localizer/src/state_transition.cpp 100.00% <ø> (ø)
...y_planner/include/utilization/trajectory_utils.hpp 0.00% <0.00%> (ø)
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)
..._smoother/analytical_jerk_constrained_smoother.cpp 0.00% <0.00%> (ø)
...n_velocity_smoother/src/smoother/smoother_base.cpp 0.00% <0.00%> (ø)
...ms/test/src/test_freespace_planning_algorithms.cpp 55.68% <14.28%> (-0.03%) ⬇️
...ace_planning_algorithms/src/abstract_algorithm.cpp 83.80% <50.00%> (+2.07%) ⬆️
...eespace_planning_algorithms/abstract_algorithm.hpp 57.14% <100.00%> (+7.14%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@esteve esteve merged commit 8684d2a into autowarefoundation:main Feb 7, 2023
@esteve esteve deleted the add_nlohmann_json3_dep branch February 7, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants