Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freespace_planning_algorithms): set goal z to path #2797

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Feb 2, 2023

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

set goal z to path

before

Screenshot from 2023-02-02 16-04-50

after

Screenshot from 2023-02-02 16-16-25

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 2, 2023
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 11.63% // Head: 11.69% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (5bf912c) compared to base (d6c0c09).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
+ Coverage   11.63%   11.69%   +0.06%     
==========================================
  Files        1317     1317              
  Lines       91839    91912      +73     
  Branches    24382    24421      +39     
==========================================
+ Hits        10681    10751      +70     
+ Misses      70007    70006       -1     
- Partials    11151    11155       +4     
Flag Coverage Δ *Carryforward flag
differential 61.59% <100.00%> (?)
total 11.63% <100.00%> (ø) Carriedforward from d6c0c09

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ude/freespace_planning_algorithms/astar_search.hpp 88.88% <ø> (+1.38%) ⬆️
...freespace_planning_algorithms/src/astar_search.cpp 78.76% <100.00%> (+7.79%) ⬆️
...ning/freespace_planning_algorithms/src/rrtstar.cpp 65.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 231f70c into autowarefoundation:main Feb 2, 2023
@kosuke55 kosuke55 deleted the fix/freespace_z branch February 2, 2023 09:00
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants