Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_avoidance_planner): clean up the code #2796

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Feb 2, 2023

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

Refactored obstacle_avoidance_planner

NOTE

  • The default trajectory length for optimization (MPT and EB) is 1.0m * 100points = 100m.
  • Curvature calculated from the input path is not used in MPT since the optimization result will be unstable for some reason.

Scenario Test
https://evaluation.tier4.jp/evaluation/reports/badb956d-c52a-5966-b68b-2f4ca4822259?project_id=prd_jt

TODO

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 2, 2023
@takayuki5168 takayuki5168 added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 2, 2023
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-avoidance-planner branch from 5eff502 to 9f56601 Compare February 6, 2023 08:39
@github-actions github-actions bot removed the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 6, 2023
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-avoidance-planner branch 2 times, most recently from af813c3 to 3d64319 Compare February 9, 2023 15:38
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-avoidance-planner branch from c08e983 to 422797b Compare February 16, 2023 18:04
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Patch coverage: 29.62% and project coverage change: +0.50 🎉

Comparison is base (7d15fdf) 11.65% compared to head (d991c39) 12.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2796      +/-   ##
==========================================
+ Coverage   11.65%   12.16%   +0.50%     
==========================================
  Files        1314     1324      +10     
  Lines       92818    93315     +497     
  Branches    25008    25294     +286     
==========================================
+ Hits        10821    11354     +533     
+ Misses      70646    70261     -385     
- Partials    11351    11700     +349     
Flag Coverage Δ *Carryforward flag
differential 13.67% <29.62%> (?)
total 11.73% <ø> (+0.07%) ⬆️ Carriedforward from 7d15fdf

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/interpolation/spline_interpolation_points_2d.hpp 83.33% <ø> (ø)
...lanner/include/obstacle_avoidance_planner/node.hpp 0.00% <0.00%> (ø)
...vehicle_model/vehicle_model_bicycle_kinematics.hpp 100.00% <ø> (ø)
...ng/obstacle_avoidance_planner/src/debug_marker.cpp 0.00% <0.00%> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 51.96% <ø> (+7.60%) ⬆️
...cle_avoidance_planner/src/utils/geometry_utils.cpp 0.00% <0.00%> (ø)
...optimizer/src/static_centerline_optimizer_node.cpp 26.83% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 13.46% <11.57%> (+13.34%) ⬆️
...terpolation/src/spline_interpolation_points_2d.cpp 50.49% <28.57%> (+15.44%) ⬆️
...tacle_avoidance_planner/utils/trajectory_utils.hpp 37.50% <37.50%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-avoidance-planner branch 2 times, most recently from f080ce5 to 34d3837 Compare February 24, 2023 10:11
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 24, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review February 28, 2023 00:42
…_planning_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-avoidance-planner branch from 269bce9 to f623650 Compare February 28, 2023 04:00
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

pre-commit.ci run

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 91653ad into autowarefoundation:main Mar 1, 2023
@takayuki5168 takayuki5168 deleted the refactor/obstacle-avoidance-planner branch March 1, 2023 01:01
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…dation#2796)

* update obstacle avoidance planner, static centerline optimizer, tier4_planning_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update velocity on joint and correct trajectory z

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor change

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…dation#2796)

* update obstacle avoidance planner, static centerline optimizer, tier4_planning_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update velocity on joint and correct trajectory z

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor change

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* pre-commit

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@mehmetdogru @beyzanurkaya
Sorry to share this with you late, but the following PRs' modification, which was recently merged, was removed with this large refactoring PR.
I will try to import the modification soon.

@mehmetdogru
Copy link
Contributor

@takayuki5168 I guess we will import the missing functionalities if you don't mind?

@takayuki5168
Copy link
Contributor Author

@mehmetdogru
Ah, I'm so sorry to forget them.
Of course, it's fine for me that you will import them.
(FYI: If you want me to do it, I can start importing from July.)

@mehmetdogru
Copy link
Contributor

@takayuki5168 no worries at all 😄 Then we will create the related PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants