Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): check if bounds_candidates is empty for debug marker #2785

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 31, 2023

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

the node will die when bonds is empty by accessing bounds_candidates.at(i)

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…for debug marker

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 requested review from takayuki5168 and a team as code owners January 31, 2023 14:02
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 11.63% // Head: 11.63% // No change to project coverage 👍

Coverage data is based on head (62a982c) compared to base (5940ba7).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2785   +/-   ##
=======================================
  Coverage   11.63%   11.63%           
=======================================
  Files        1317     1317           
  Lines       91819    91819           
  Branches    24371    24371           
=======================================
  Hits        10679    10679           
  Misses      69990    69990           
  Partials    11150    11150           
Flag Coverage Δ *Carryforward flag
differential 17.30% <0.00%> (?)
total 11.63% <0.00%> (ø) Carriedforward from 5940ba7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...stacle_avoidance_planner/src/utils/debug_utils.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit 66753e8 into autowarefoundation:main Feb 3, 2023
@kosuke55 kosuke55 deleted the fix/obstacle_avoidance_bounds_marker branch February 3, 2023 01:54
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
…for debug marker (autowarefoundation#2785)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants