fix(behavior_path_planner): fix pull out module when enable_back is false #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alse Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportBase: 11.66% // Head: 11.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
- Coverage 11.66% 11.65% -0.02%
==========================================
Files 1314 1314
Lines 91572 91660 +88
Branches 24366 24429 +63
==========================================
Hits 10679 10679
- Misses 69743 69829 +86
- Partials 11150 11152 +2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1222-takeshi
approved these changes
Jan 30, 2023
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 31, 2023
…alse (autowarefoundation#2779) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
7 tasks
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 31, 2023
…alse (autowarefoundation#2779) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 31, 2023
…alse (autowarefoundation#2779) (#265) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
lexavtanke
pushed a commit
to lexavtanke/autoware.universe
that referenced
this pull request
Jan 31, 2023
…alse (autowarefoundation#2779) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
asana17
pushed a commit
to asana17/autoware.universe
that referenced
this pull request
Feb 8, 2023
…alse (autowarefoundation#2779) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp
Description
When
enable_backis false, the pull_over module does not publish a valid path with the following message.It is because in
planWithPriorityOnEfficientPathorplanWithPriorityOnShortBackDistanceno process runs when the size ofstart_pose_candidatesis 1. I fixed it.Related links
Tests performed
Tested on planning simulator （enable_back=true/false）
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.