Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add random id to route #2746

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jan 25, 2023

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Add random id to route. It's random id instead of uuid for now.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 11.52% // Head: 11.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f8976e4) compared to base (b7b0188).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2746    +/-   ##
========================================
  Coverage   11.52%   11.52%            
========================================
  Files        1305     1305            
  Lines       91225    91344   +119     
  Branches    24172    24200    +28     
========================================
+ Hits        10510    10529    +19     
- Misses      69720    69810    +90     
- Partials    10995    11005    +10     
Flag Coverage Δ *Carryforward flag
differential 21.07% <0.00%> (?)
total 11.52% <0.00%> (ø) Carriedforward from b7b0188

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...on_planner/src/mission_planner/arrival_checker.cpp 0.00% <0.00%> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
planning/static_centerline_optimizer/src/utils.cpp 33.33% <0.00%> (+4.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 self-requested a review January 31, 2023 12:44
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!
It woks well. LGTM

image

@kosuke55
Copy link
Contributor

kosuke55 commented Feb 1, 2023

@TakaHoribe @takayuki5168 @mitsudome-r
Could you please approve it as a code owner?:pray:

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55
Copy link
Contributor

@isamu-takagi
Please merge unless there is something left to do.

@isamu-takagi isamu-takagi merged commit a2ba6dc into autowarefoundation:main Feb 14, 2023
@isamu-takagi isamu-takagi deleted the feat/mission-planner-uuid branch February 14, 2023 07:02
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 16, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jun 20, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants