Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(detected_object_validation): add build dependency #2735

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jan 24, 2023

Description

See autowarefoundation/autoware#3222

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve requested review from yukkysaito and a team as code owners January 24, 2023 15:15
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 11.55% // Head: 11.55% // No change to project coverage 👍

Coverage data is based on head (28777e1) compared to base (403713d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2735   +/-   ##
=======================================
  Coverage   11.55%   11.55%           
=======================================
  Files        1309     1309           
  Lines       91342    91342           
  Branches    24231    24231           
=======================================
  Hits        10550    10550           
  Misses      69752    69752           
  Partials    11040    11040           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.55% <0.00%> (ø) Carriedforward from 403713d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../lane_departure_checker/lane_departure_checker.hpp 0.00% <ø> (ø)
..._departure_checker_node/lane_departure_checker.cpp 0.00% <0.00%> (ø)
...rture_checker_node/lane_departure_checker_node.cpp 0.40% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <ø> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the add-build-depend-detected_object_validation branch from cf027f2 to 28777e1 Compare January 24, 2023 15:45
@esteve esteve enabled auto-merge (squash) January 24, 2023 15:45
@esteve
Copy link
Contributor Author

esteve commented Jan 27, 2023

@yukkysaito could you review this PR when you have a moment? Thanks.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@esteve esteve merged commit 8c7b2c1 into autowarefoundation:main Jan 27, 2023
@esteve esteve deleted the add-build-depend-detected_object_validation branch January 27, 2023 16:11
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
asana17 pushed a commit to asana17/autoware.universe that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants