Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_control_launch): remove parameter definition in control.launch.py #2585

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 26, 2022

Description

  • moved parameter definition from control.launch.py to *.param.yaml
    image

  • removed the default parameter of declare_paremeter in the modules which I modified.

related PRs

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 26, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 changed the title Refactor/organize control launch refactor(tier4_control_launch): remove parameter definition in control.launch.py Dec 26, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review December 26, 2022 09:13
@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Dec 26, 2022

@TakaHoribe
I've confirmed this PR woks well with psim.

P.S. worked well with tier4/ and awf/ respectively.

Could you review the PR. After this PR, I will remove control_launch from tier4/autoware_launch and use tier4_control_launch instead.

@takayuki5168 takayuki5168 marked this pull request as draft December 26, 2022 09:20
@takayuki5168 takayuki5168 marked this pull request as ready for review December 26, 2022 09:26
@takayuki5168
Copy link
Contributor Author

@TakaHoribe Now it's ready to merge for me.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 10.52% // Head: 10.58% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (c3aaaf6) compared to base (0462fa6).
Patch coverage: 3.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
+ Coverage   10.52%   10.58%   +0.06%     
==========================================
  Files        1270     1270              
  Lines       88143    88270     +127     
  Branches    21225    21354     +129     
==========================================
+ Hits         9275     9342      +67     
- Misses      68978    68979       +1     
- Partials     9890     9949      +59     
Flag Coverage Δ *Carryforward flag
differential 21.26% <0.00%> (?)
total 10.52% <3.57%> (ø) Carriedforward from 0462fa6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ternal_cmd_selector/external_cmd_selector_node.cpp 0.00% <0.00%> (ø)
...l/trajectory_follower_node/src/controller_node.cpp 38.09% <0.00%> (-0.37%) ⬇️
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.29% <0.00%> (ø)
...ectory_follower_node/test/test_controller_node.cpp 32.63% <25.00%> (+8.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 0f96564 into autowarefoundation:main Dec 28, 2022
@takayuki5168 takayuki5168 deleted the refactor/organize-control-launch branch December 28, 2022 03:11
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…l.launch.py (autowarefoundation#2585)

* refactor trajectory_follower_node's param

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* organize parameter definition in control_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix typo

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix failed test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
xmfcx added a commit to sujithvemi/autoware.universe that referenced this pull request Jan 10, 2023
commit c0d9d80
Merge: c6ccf4f be31385
Author: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Date:   Tue Jan 10 17:16:43 2023 +0300

    Merge branch 'main' into 1121-detection_area_module_debug_markers_no_obstacles_new

commit be31385
Author: Berkay Karaman <brkay54@gmail.com>
Date:   Tue Jan 10 16:08:04 2023 +0300

    feat(vehicle_cmd_gate): send current gear if autoware is not engaged (autowarefoundation#2555)

    * feat(vehicle_cmd_gate): send current gear if autoware is not engaged

    Signed-off-by: Berkay Karaman <brkay54@gmail.com>

    * ci(pre-commit): autofix

    * add topic map to launch file

    Signed-off-by: Berkay Karaman <brkay54@gmail.com>

    Signed-off-by: Berkay Karaman <brkay54@gmail.com>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 732bc9c
Author: Tomohito ANDO <tomohito.ando@tier4.jp>
Date:   Tue Jan 10 18:35:50 2023 +0900

    chore: fix typo (autowarefoundation#2625)

    Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

    Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

commit 30277d1
Author: Takamasa Horibe <horibe.takamasa@gmail.com>
Date:   Tue Jan 10 16:32:50 2023 +0900

    docs(freespace-planner): fix syntax error (autowarefoundation#2376)

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

commit a7e322d
Author: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>
Date:   Tue Jan 10 14:16:57 2023 +0900

    feat(behavior_path_planner): fix steering factor not publishing during turning (autowarefoundation#2587)

    fix steering factor not publishing during turning

    Signed-off-by: tkhmy <tkh.my.p@gmail.com>

    Signed-off-by: tkhmy <tkh.my.p@gmail.com>

commit 9b8d079
Author: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Date:   Sun Jan 8 20:50:53 2023 +0900

    feat(tensorrt_yolox): add yolox launch (autowarefoundation#2598)

    * feat(tensorrt_yolox): add yolox launch

    Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

    * add use_decompress option

    Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

    * ci(pre-commit): autofix

    * Apply suggestions from code review

    changes the topic name

    Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

    Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>

commit f1de244
Author: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Date:   Sun Jan 8 16:35:07 2023 +0900

    fix(behavior_path_planner): consider length for unavoidable objects around the goal (autowarefoundation#2617)

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

commit 132c154
Author: Mehmet Dogru <48479081+mehmetdogru@users.noreply.github.com>
Date:   Fri Jan 6 10:23:32 2023 +0300

    fix(obstacle_avoidance_planner): fix lat_dist_to_front_bound comparison (autowarefoundation#2594)

    * fix(obstacle_avoidance_planner): fix lat_dist_to_front_bound comparison

    Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

    * fix: update comment

    Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

    Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

commit 316f5e9
Author: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Date:   Thu Jan 5 18:22:11 2023 +0900

    fix(avoidance): ignore unavoidable objects around the goal (autowarefoundation#2612)

    * fix(avoidance): ignore unavoidable objects around the goal

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * Update planning/behavior_path_planner/config/avoidance/avoidance.param.yaml

    * Update planning/behavior_path_planner/src/behavior_path_planner_node.cpp

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
    Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

commit fe91a4a
Author: kminoda <44218668+kminoda@users.noreply.github.com>
Date:   Thu Jan 5 15:20:49 2023 +0900

    fix(tier4_perception_launch): sync with tier4/autoware_launch (autowarefoundation#2568)

    * fix(tier4_perception_launch): sync with tier4/autoware_launch

    Signed-off-by: kminoda <koji.minoda@tier4.jp>

    * move centerpoint configs to perception.launch.xml

    Signed-off-by: kminoda <koji.minoda@tier4.jp>

    Signed-off-by: kminoda <koji.minoda@tier4.jp>

commit 0f04622
Author: Ryuta Kambe <veqcc.c@gmail.com>
Date:   Thu Jan 5 11:08:56 2023 +0900

    perf(behavior_velocity_planner): remove pose.orientation from occlusion_spot (autowarefoundation#2591)

commit 2476573
Author: Yukihiro Saito <yukky.saito@gmail.com>
Date:   Wed Jan 4 23:19:06 2023 +0900

    chore(planning-sim): change debug topic name (autowarefoundation#2610)

    Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

    Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

commit 6992bc5
Author: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Date:   Wed Jan 4 09:24:01 2023 +0900

    feat(behavior path planner): lane change cancel/abort docs update (autowarefoundation#2599)

    * feat(behavior path planner): lane change cancel/abort docs update

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * Update parameters and it's config (yaml) file

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

commit 0fc033e
Author: Kaan Çolak <kaancolak95@gmail.com>
Date:   Tue Jan 3 16:09:24 2023 +0300

    fix(pointcloud_preprocessor): remove unused library (autowarefoundation#2593)

    Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

    Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>

commit 64ec4cf
Author: NorahXiong <103234047+NorahXiong@users.noreply.github.com>
Date:   Sat Dec 31 14:54:29 2022 +0800

    perf(freespace_planning_algorithms): improve freespace planning performance (autowarefoundation#2040)

    * perf(freespace_planning_algorithms): eliminate unnecessary calculation steps in collision detection function

    Signed-off-by: NorahXiong <norah.xiong@autocore.ai>

    * perf(freespace_planning_algorithms): improve node data storage

    Signed-off-by: NorahXiong <norah.xiong@autocore.ai>

    * ci(pre-commit): autofix

    * ci(pre-commit): autofix

    * fix(freespace_planning_algorithms): reset data explicitly as class object construction strategy changed

    Signed-off-by: NorahXiong <norah.xiong@autocore.ai>

    Signed-off-by: NorahXiong <norah.xiong@autocore.ai>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit b844cb1
Author: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Date:   Fri Dec 30 16:35:39 2022 +0900

    fix(behavior_path_planner): pull over emergency stop (autowarefoundation#2601)

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

commit 0a7b74d
Author: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Date:   Wed Dec 28 17:15:36 2022 +0900

    feat(behavior_path_planner): abort lane change function (autowarefoundation#2359)

    * feat(behavior_path_planner): abort lane change function

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * change Revert -> Cancel

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * Remove some unwanted functions and and STOP state

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * update steering factor (accidentally removed)

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * include is_abort_condition_satisfied_ flag

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * use only check ego in current lane

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * Revert "use only check ego in current lane"

    This reverts commit 4f97408.

    * ci(pre-commit): autofix

    * use only check ego in current lane

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * improve isAbortConditionSatisfied by using ego polygon check

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * add lateral jerk and path doesn't keep on updating anymore

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * parameterized all abort related values

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * rename abort_end -> abort_return

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * fix some parameter issue

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * check if lane change distance is enough after abort

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * improve the code flow of isAbortConditionSatisfied

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * Place warning message in corresponding states.

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * fix clock and rebase

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * remove accel and jerk parameters

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * remove unnecessary parameters

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * fix param file in config

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * Update planning/behavior_path_planner/src/scene_module/lane_change/util.cpp

    Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * remove isStopState and refactoring

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * Fixed CANCEL when ego is out of lane

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * fix path reset during abort

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * fix abort path exceed goal

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * fix logger to debug

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

commit 0f96564
Author: Takayuki Murooka <takayuki5168@gmail.com>
Date:   Wed Dec 28 12:11:47 2022 +0900

    refactor(tier4_control_launch): remove parameter definition in control.launch.py (autowarefoundation#2585)

    * refactor trajectory_follower_node's param

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * organize parameter definition in control_launch

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix typo

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix failed test

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

commit 0483c70
Author: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Date:   Wed Dec 28 12:08:34 2022 +0900

    fix(path_shifter): fix log level for nominal case (autowarefoundation#2596)

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

commit 40ad116
Author: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Date:   Wed Dec 28 11:34:51 2022 +0900

    feat(rtc_auto_mode_manager)!: add auto mode status array (autowarefoundation#2517)

    * feat(rtc_aut_mode_manager)!: add auto mode status array

    Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

    * chore:  planning/rtc_auto_mode_manager/src/rtc_auto_mode_manager_interface.cpp

    Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

commit 19a7ba5
Author: Takayuki Murooka <takayuki5168@gmail.com>
Date:   Wed Dec 28 10:26:06 2022 +0900

    test(static_centerline_optimizer): add launch_testing-based test (autowarefoundation#2589)

    * test(static_centerline_optimizer): add launch_testing-based test

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * update

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * add_ros_test -> add_launch_test

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

commit 1ac7cd3
Author: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Date:   Wed Dec 28 09:53:54 2022 +0900

    fix(behavior_path_planner): reduce path shifter log (autowarefoundation#2592)

    Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp>

    Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp>

commit 8704ce9
Author: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Date:   Wed Dec 28 09:25:09 2022 +0900

    fix(simple_planning_simulator): fix ideal steer acc calc (autowarefoundation#2595)

    Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

    Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

commit 3cd453b
Author: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Date:   Wed Dec 28 01:15:48 2022 +0900

    feat(behavior_path_planner): generate pull over path candidates in advance (autowarefoundation#2578)

    * feat(behavior_path_planner): generate pull over path candidates in advance

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

    * add update

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

    * Update planning/behavior_path_planner/src/scene_module/pull_over/goal_searcher.cpp

    Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

    * Update planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp

    Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

    * copy for multithread

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
    Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

commit 175e23d
Author: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Date:   Tue Dec 27 17:51:45 2022 +0900

    fix(crosswalk): fix base path for stop point caluculation (autowarefoundation#2584)

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

commit d204932
Author: Mamoru Sobue <mamoru.sobue@tier4.jp>
Date:   Tue Dec 27 16:41:10 2022 +0900

    fix(intersection): fix logger level (autowarefoundation#2582)

    Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

    Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

commit 4548a1f
Author: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Date:   Tue Dec 27 14:07:53 2022 +0900

    fix(external_velocity_limit_selector): increase history depth external velocity limit selector (autowarefoundation#2581)

    * fix(external_velocity_limit_selector): increase history depth

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * feat(external_velocity_limit_selector): publish string for debug

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * feat(external_velocity_limit_selector): remap debug topic

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

commit ed1a230
Author: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Date:   Tue Dec 27 14:05:42 2022 +0900

    chore: update CODEOWNERS (autowarefoundation#2586)

    Signed-off-by: GitHub <noreply@github.com>

    Signed-off-by: GitHub <noreply@github.com>
    Co-authored-by: satoshi-ota <satoshi-ota@users.noreply.github.com>

commit c52efb5
Author: Tomoya Kimura <tomoya.kimura@tier4.jp>
Date:   Tue Dec 27 13:44:36 2022 +0900

    feat(external_velocity_limit_selector): add code owners (autowarefoundation#2588)

    * feat(external_velocity_limit_selector): add code owners

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

    * fix(external_velocity_limit_selector): run pre-commit

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
    Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>

commit e9988e9
Author: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Date:   Tue Dec 27 11:39:53 2022 +0900

    feat(default_ad_api): add planning api (autowarefoundation#2481)

    * feat(default_ad_api): add planning api

    Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

    * feat: complement velocity factor

    Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

    * feat: add stop check

    Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

    * feat: make the same process into a function

    Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

    * feat: update visualizer

    Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

    * fix: remove flake8 test

    Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

    Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

commit 3396329
Author: Takayuki Murooka <takayuki5168@gmail.com>
Date:   Mon Dec 26 16:50:56 2022 +0900

    refactor(pure_pursuit): minor refactoring for trajectory_follower_node (autowarefoundation#2583)

    * refactor(pure_pursuit): minor refactoring for trajectory_follower_node

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * removed self_pose_listener

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

commit 0462fa6
Author: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Date:   Mon Dec 26 13:58:08 2022 +0900

    chore: update CODEOWNERS (autowarefoundation#2456)

    Signed-off-by: GitHub <noreply@github.com>

    Signed-off-by: GitHub <noreply@github.com>
    Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

commit d17ba4f
Author: Takayuki Murooka <takayuki5168@gmail.com>
Date:   Mon Dec 26 13:05:32 2022 +0900

    feat(trajectory_follower): seperate lat lon controller packages (autowarefoundation#2580)

    * feat(trajectory_follower): seperate controller implementation packages

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * update doc

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix doc

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix test

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * rename: mpc_follower -> mpc

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * rename to trajectory_follower_base, trajectory_follower_node

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix doc

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * remove unnecessary change

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

commit c98bdbc
Author: Takayuki Murooka <takayuki5168@gmail.com>
Date:   Mon Dec 26 13:00:45 2022 +0900

    fix(obstacle_avoidance_planner): add guard for too large yaw deviation (autowarefoundation#2579)

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

commit 773ef53
Author: Tomoya Kimura <tomoya.kimura@tier4.jp>
Date:   Mon Dec 26 11:37:03 2022 +0900

    fix(obstacle_avoidance_planner): add guard for empty points array to prevent dying (autowarefoundation#2557)

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

commit 8f6ae1b
Author: Tomoya Kimura <tomoya.kimura@tier4.jp>
Date:   Mon Dec 26 11:08:10 2022 +0900

    chore(behavior_path_planner): make the line of drivable are bound bolder (autowarefoundation#2563)

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

commit 95731ff
Author: Tomoya Kimura <tomoya.kimura@tier4.jp>
Date:   Mon Dec 26 10:13:07 2022 +0900

    fix(behavior_velocity_planner): fix blind spot over-detection (autowarefoundation#2570)

    * chore: sync files (autowarefoundation#629)

    * chore: sync files

    Signed-off-by: GitHub <noreply@github.com>

    * ci(pre-commit): autofix

    Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

    * feat(map_based_prediction): set orientation to predicted path of pedestrian

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

    Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
    Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit fe12eb8
Author: Takayuki Murooka <takayuki5168@gmail.com>
Date:   Mon Dec 26 10:04:08 2022 +0900

    fix(mission_planner): fix initialize function (autowarefoundation#2566)

    * fix(mission_planner): fix initialize function

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

commit 5070130
Author: Takayuki Murooka <takayuki5168@gmail.com>
Date:   Sat Dec 24 23:40:42 2022 +0900

    refactor(trajectory_follower_nodes): refactor the controller framework (autowarefoundation#2432)

    * refactor(trajectory_follower_nodes): refactor the controller framework

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * add test for keeping stopped state when steer is not converged

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * fix the bug that initialization of mpc does not finish

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * apply the change to pure_pursuit

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * remove initialize function and implement reset function

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    * minor change

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

    Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

commit 29086e5
Author: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Date:   Sat Dec 24 14:11:07 2022 +0900

    feat(avoidance): implement avoidance path safety check logic (autowarefoundation#2534)

    * feat(avoidance_utils): add util functions

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * feat(avoidance): add safety check for avoidance path

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * feat(avoidance): enhance avoidance debug marker

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * fix(avoidance): not use smoother

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * feat(behavior_path_planner): add utility function

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * fix(avoidance): use other util function

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * fix(avoidance): use emplace_back

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * fix(behavior_path_planner): use new util funciton

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * fix(behaivior_path_planner): remove unused util function

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    * fix(avoidance): not use make pair in emplace back

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

    Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

commit da1b16e
Author: Takamasa Horibe <horibe.takamasa@gmail.com>
Date:   Fri Dec 23 18:45:01 2022 +0900

    feat(lane_change): update path generation logic to consider lateral jerk and lateral acceleration (autowarefoundation#2428)

    * [lane_change] update path generation to handle lateral acceleration limit

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * remove unused code

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * remove unused code & fix precommit

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * update doc

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * update docs

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * update doc

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * update doc

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * update doc

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * move path_shifter implementation to cpp

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * Update planning/behavior_path_planner/src/scene_module/utils/path_shifter.cpp

    Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

    * Update planning/behavior_path_planner/behavior_path_planner_path_generation.md

    Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

    * update doc link

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * update doc

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * remove unused code

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    * add common min distance computation

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * rearrange config and rework min distance

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * revert some changes

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * remove warning

    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    * Update planning/behavior_path_planner/behavior_path_planner_path_generation.md

    Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

    * Update planning/behavior_path_planner/behavior_path_planner_path_generation.md

    Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

    * fix spell check

    Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
    Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
    Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
    Co-authored-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
    Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>

commit c3d39d6
Author: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Date:   Fri Dec 23 17:53:27 2022 +0900

    fix(behavior_path_planner): lane change check default parameters (autowarefoundation#2575)

    Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp>

    Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp>

commit d969e52
Author: Fumiya Watanabe <rej55.g@gmail.com>
Date:   Fri Dec 23 16:16:21 2022 +0900

    fix(behavior_path_planner): return node status in each scene modules (autowarefoundation#2577)

    * fix(behavior_path_planner): return node status in each scene modules

    Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

    * fix(behavior_path_planner): fix typo

    Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

    * Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/scene_module_interface.hpp

    Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

    Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
    Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

commit 03facbf
Author: Takamasa Horibe <horibe.takamasa@gmail.com>
Date:   Fri Dec 23 14:16:11 2022 +0900

    refactor(oepration__mode_transition_manager): improve visibility for debug topic (autowarefoundation#2573)

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

    Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

commit 065affc
Author: kminoda <44218668+kminoda@users.noreply.github.com>
Date:   Fri Dec 23 13:57:51 2022 +0900

    fix(localization_error_monitor): fix CMakeLists.txt (autowarefoundation#2576)

    Signed-off-by: kminoda <koji.minoda@tier4.jp>

    Signed-off-by: kminoda <koji.minoda@tier4.jp>

commit fa8ab7d
Author: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Date:   Fri Dec 23 13:14:08 2022 +0900

    fix(behavior_path_planner): pull over emergency stop velocity  (autowarefoundation#2572)

    * fix(behavior_path_planner): pull over emergency stop velocity

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

    * make exp_vel

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

    Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

commit c558ecd
Author: Taichi Hirano <85976747+td12321@users.noreply.github.com>
Date:   Fri Dec 23 12:24:34 2022 +0900

    docs(accel_brake_map_calibrator): add calibration_method description (autowarefoundation#2466)

    * add calibration_method description.

    * apply formatter

    Signed-off-by: takahoribe <horibe.takamasa@gmail.com>

    * update doc

    Signed-off-by: takahoribe <horibe.takamasa@gmail.com>

    Signed-off-by: takahoribe <horibe.takamasa@gmail.com>
    Co-authored-by: takahoribe <horibe.takamasa@gmail.com>

commit c958fdd
Author: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
Date:   Fri Dec 23 10:03:40 2022 +0900

    feat(behavior_velocity_planner): change planner data update (autowarefoundation#2531)

    Signed-off-by: yutaka <purewater0901@gmail.com>

    Signed-off-by: yutaka <purewater0901@gmail.com>

commit 1f41e67
Author: kminoda <44218668+kminoda@users.noreply.github.com>
Date:   Fri Dec 23 09:23:59 2022 +0900

    fix(gyro_odometer): fix output frame (autowarefoundation#2562)

    Signed-off-by: kminoda <koji.minoda@tier4.jp>

    Signed-off-by: kminoda <koji.minoda@tier4.jp>

commit db37c87
Author: Xinyu Wang <93699235+angry-crab@users.noreply.github.com>
Date:   Fri Dec 23 08:35:39 2022 +0900

    refactor(tvm_utility): redefine network node and inference config (autowarefoundation#2467)

    * redefine network node and inference config

    Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

    * accomondate network node changes

    Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

    * ci(pre-commit): autofix

    * revert device type and id

    Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

    * cmake setting

    Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

    * data type and modelzoo version

    Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

    Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
    Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

commit 7ecbbc7
Author: Mamoru Sobue <mamoru.sobue@tier4.jp>
Date:   Fri Dec 23 05:57:42 2022 +0900

    fix(intersection): additional fix for autowarefoundation#2463 (autowarefoundation#2565)

    * always set RTC distance to default stop line

    Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

    * add code owner

    Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

commit c6ccf4f
Merge: e1e0538 a26b69d
Author: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Date:   Wed Dec 14 12:34:55 2022 +0900

    Merge branch 'main' into 1121-detection_area_module_debug_markers_no_obstacles_new

commit e1e0538
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Mon Dec 12 14:28:10 2022 +0000

    ci(pre-commit): autofix

commit c411d37
Merge: d50711b 417bfe9
Author: sujithvemi <sujith.3920@gmail.com>
Date:   Mon Dec 12 19:54:41 2022 +0530

    Merge branch '1121-detection_area_module_debug_markers_no_obstacles_new' of https://github.com/sujithvemi/autoware.universe into 1121-detection_area_module_debug_markers_no_obstacles_new

commit d50711b
Author: sujithvemi <sujith.3920@gmail.com>
Date:   Mon Dec 12 17:20:20 2022 +0530

    What: Changed the data type of marker color to use the existing standard ROS2 message format instead of custom defined struct

commit 31b380e
Author: sujithvemi <sujith.3920@gmail.com>
Date:   Tue Nov 29 11:27:53 2022 +0530

    What: Added different color feature for detection area, resolves issue 1121

    Signed-off-by: sujithvemi <sujith.3920@gmail.com>

commit 417bfe9
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date:   Mon Dec 12 12:00:31 2022 +0000

    ci(pre-commit): autofix

commit 989bb7e
Author: sujithvemi <sujith.3920@gmail.com>
Date:   Mon Dec 12 17:20:20 2022 +0530

    What: Changed the data type of marker color to use the existing standard ROS2 message format instead of custom defined struct

commit 9e0b7d5
Author: sujithvemi <sujith.3920@gmail.com>
Date:   Tue Nov 29 11:27:53 2022 +0530

    What: Added different color feature for detection area, resolves issue 1121

    Signed-off-by: sujithvemi <sujith.3920@gmail.com>

commit a829edd
Author: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Date:   Tue Nov 29 11:26:07 2022 +0000

    chore: update CODEOWNERS (autowarefoundation#2400)

    Signed-off-by: GitHub <noreply@github.com>

    Signed-off-by: GitHub <noreply@github.com>
    Co-authored-by: takayuki5168 <takayuki5168@users.noreply.github.com>
    Signed-off-by: sujithvemi <sujith.3920@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants