Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lidar_centerpoint): updated centerpoint models and documentation #2553

Merged
merged 6 commits into from
Dec 22, 2022

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Dec 21, 2022

Signed-off-by: Kenzo Lobos-Tsunekawa kenzo.lobos@tier4.jp

Description

Add new centerpoint models trained in argoverse2 and nuscenes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 10.54% // Head: 10.55% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (985ab9b) compared to base (0c93a2c).
Patch coverage: 3.87% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2553   +/-   ##
=======================================
  Coverage   10.54%   10.55%           
=======================================
  Files        1268     1267    -1     
  Lines       87604    87599    -5     
  Branches    20931    20938    +7     
=======================================
  Hits         9242     9242           
+ Misses      68499    68492    -7     
- Partials     9863     9865    +2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.55% <3.87%> (+<0.01%) ⬆️ Carriedforward from ddc9b5b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/scene_module/pull_out/pull_out_module.hpp 0.00% <ø> (ø)
...nner/scene_module/pull_out/pull_out_parameters.hpp 0.00% <ø> (ø)
...h_planner/scene_module/pull_out/shift_pull_out.hpp 0.00% <ø> (ø)
...nner/scene_module/pull_over/goal_searcher_base.hpp 0.00% <ø> (ø)
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
...er/scene_module/pull_over/pull_over_parameters.hpp 0.00% <ø> (ø)
.../scene_module/pull_over/pull_over_planner_base.hpp 0.00% <ø> (ø)
...planner/scene_module/pull_over/shift_pull_over.hpp 0.00% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 29.41% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.18% <0.00%> (ø)
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knzo25 knzo25 changed the title Added documentation for the new models chore(lidar_centerpoint): updated centerpoint models and documentation Dec 22, 2022
@knzo25 knzo25 marked this pull request as ready for review December 22, 2022 05:38
@knzo25 knzo25 requested review from yukke42 and a team as code owners December 22, 2022 05:38
knzo25 and others added 2 commits December 22, 2022 15:39
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25 knzo25 merged commit 98b1cf3 into main Dec 22, 2022
@knzo25 knzo25 deleted the feature/lidar_centerpoint_new_models branch December 22, 2022 08:46
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
autowarefoundation#2553)

* Added documentation for the new models

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Changed the model links' in the CMakeList

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/lidar_centerpoint/README.md

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

* Added the raw links in the README

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants