Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_cruise_planner): clean up the code #2526

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 19, 2022

Description

clean up the code

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 19, 2022
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 19, 2022
@takayuki5168 takayuki5168 changed the title Refactor/obstacle cruise planner refactor(obstacle_cruise_planner): clean up the code Dec 19, 2022
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-cruise-planner branch from fe260b2 to 46fc5ba Compare December 19, 2022 10:24
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 10.54% // Head: 10.45% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (3e658a9) compared to base (ee9a389).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2526      +/-   ##
==========================================
- Coverage   10.54%   10.45%   -0.10%     
==========================================
  Files        1266     1267       +1     
  Lines       87617    88432     +815     
  Branches    20952    20952              
==========================================
  Hits         9242     9242              
- Misses      68512    69327     +815     
  Partials     9863     9863              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.54% <0.00%> (ø) Carriedforward from 52a587c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/obstacle_cruise_planner/common_structs.hpp 0.00% <0.00%> (ø)
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <ø> (ø)
...se_planner/pid_based_planner/pid_based_planner.hpp 0.00% <ø> (ø)
...lude/obstacle_cruise_planner/planner_interface.hpp 0.00% <0.00%> (ø)
..._planner/include/obstacle_cruise_planner/utils.hpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...ation_based_planner/optimization_based_planner.cpp 0.00% <0.00%> (ø)
...lanner/src/pid_based_planner/pid_based_planner.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-cruise-planner branch from aaa539c to 52a587c Compare December 20, 2022 03:42
@takayuki5168 takayuki5168 marked this pull request as ready for review December 20, 2022 03:49
@takayuki5168 takayuki5168 removed the type:documentation Creating or refining documentation. (auto-assigned) label Dec 20, 2022
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 20, 2022
@takayuki5168 takayuki5168 added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Dec 20, 2022
Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-cruise-planner branch from 7ba1343 to 3e658a9 Compare December 20, 2022 06:09
@takayuki5168 takayuki5168 merged commit febbc13 into autowarefoundation:main Dec 21, 2022
@takayuki5168 takayuki5168 deleted the refactor/obstacle-cruise-planner branch December 21, 2022 01:03
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 22, 2022
…ion#2526)

* refactor obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add vel lpf and disable_target_acceleration

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 26, 2022
…ion#2526)

* refactor obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add vel lpf and disable_target_acceleration

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…ion#2526)

* refactor obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add vel lpf and disable_target_acceleration

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants