Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_rviz_plugin): add offset from baselink param #2384

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Nov 28, 2022

Description

Add param for offset_from_baselink in the footprint visualization.

The aim is to visualize the difference in footprint when following different coordinate systems for a trajectory.
This analysis is required in path planning, e.g. the obstacle_avoidance_planner has the same parameter that sets the offset length from baselink for the path optimization algorithm.

image
When the trajectory is followed in the baselink the footprint is shown as the yellow polygon, and vehicle center coodrinate makes the red one.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 28, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the feat/trajectory-footprint-add-offset-arg branch from 08228b7 to 2b62c1f Compare November 28, 2022 06:10
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 10.48% // Head: 10.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2b62c1f) compared to base (79fadf8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
- Coverage   10.48%   10.47%   -0.01%     
==========================================
  Files        1248     1248              
  Lines       91218    91271      +53     
  Branches    21012    21012              
==========================================
  Hits         9565     9565              
- Misses      71466    71519      +53     
  Partials    10187    10187              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.46% <0.00%> (ø) Carriedforward from 79fadf8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...iz_plugin/include/trajectory_footprint/display.hpp 0.00% <ø> (ø)
...g_rviz_plugin/src/trajectory_footprint/display.cpp 0.00% <0.00%> (ø)
.../behavior_path_planner/src/turn_signal_decider.cpp 35.93% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe added the component:tools Utility and debugging software. (auto-assigned) label Nov 28, 2022
@yukkysaito
Copy link
Contributor

Why is this visualization necessary?

@github-actions github-actions bot removed the component:tools Utility and debugging software. (auto-assigned) label Nov 29, 2022
@TakaHoribe
Copy link
Contributor Author

@yukkysaito I update the docs for the purpose

The aim is to visualize the difference in footprint when following different coordinate systems for a trajectory.
This analysis is required in path planning, e.g. the obstacle_avoidance_planner has the same parameter that sets the offset length from baselink for the path optimization algorithm.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Copy link
Contributor

takayuki5168 commented Nov 30, 2022

The aim is to visualize the difference in footprint when following different coordinate systems for a trajectory.
This analysis is required in path planning, e.g. the obstacle_avoidance_planner has the same parameter that sets the offset length from baselink for the path optimization algorithm.

Just memo.
Footprints with offset_from_baselink ≒ 0 are kinematically infieasible, and the car cannot follow the footprints.
Obstacle avoidance planner solves this infeasiblity problem with optimization.

@TakaHoribe TakaHoribe enabled auto-merge (squash) December 1, 2022 12:17
@TakaHoribe TakaHoribe merged commit 00fdc47 into autowarefoundation:main Dec 1, 2022
@TakaHoribe TakaHoribe deleted the feat/trajectory-footprint-add-offset-arg branch December 1, 2022 12:17
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…owarefoundation#2384)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…owarefoundation#2384)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants