Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_threshold_filter): fix changing to autoware_cmake dependency #2366

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Nov 24, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

Fix changing to autoware_cmake dependency according to #2362 (comment)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Nov 24, 2022
@scepter914 scepter914 changed the title refactor(radar_threshold_filter_cmake): fix changing to autoware_cmake dependency refactor(radar_threshold_filter): fix changing to autoware_cmake dependency Nov 24, 2022
…ndency

Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the refactor/radar_threshold_filter_cmake branch from c462b16 to 48e46b5 Compare November 24, 2022 08:17
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 10.50% // Head: 10.62% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (feedb12) compared to base (8c6156d).
Patch coverage: 31.03% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
+ Coverage   10.50%   10.62%   +0.12%     
==========================================
  Files        1246     1239       -7     
  Lines       90972    82827    -8145     
  Branches    20973    20399     -574     
==========================================
- Hits         9555     8803     -752     
+ Misses      71256    64332    -6924     
+ Partials    10161     9692     -469     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.62% <31.03%> (+0.14%) ⬆️ Carriedforward from ef2b358

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n/motion_utils/test/src/resample/test_resample.cpp 23.61% <23.07%> (-2.26%) ⬇️
common/motion_utils/src/resample/resample.cpp 31.85% <100.00%> (-0.82%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-62.50%) ⬇️
system/default_ad_api/src/localization.cpp 0.00% <0.00%> (-37.50%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
system/default_ad_api/src/fail_safe.cpp 0.00% <0.00%> (-30.00%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...wer/include/trajectory_follower/lowpass_filter.hpp 50.00% <0.00%> (-25.00%) ⬇️
system/default_ad_api/src/operation_mode.cpp 0.00% <0.00%> (-24.10%) ⬇️
... and 822 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 requested a review from a team as a code owner November 24, 2022 17:09
@miursh miursh merged commit 61c78ac into autowarefoundation:main Nov 25, 2022
@scepter914 scepter914 deleted the refactor/radar_threshold_filter_cmake branch November 25, 2022 04:31
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…ndency (autowarefoundation#2366)

* refactor(radar_threshold_filter): fix changing to autoware_cmake dependency

Signed-off-by: scepter914 <scepter914@gmail.com>

* add code maintainer

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…ndency (autowarefoundation#2366)

* refactor(radar_threshold_filter): fix changing to autoware_cmake dependency

Signed-off-by: scepter914 <scepter914@gmail.com>

* add code maintainer

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants