Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper" #2317

Merged
merged 3 commits into from
Nov 21, 2022
Merged

revert: "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper" #2317

merged 3 commits into from
Nov 21, 2022

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Nov 18, 2022

Reverts #1276

@miursh miursh requested review from amc-nu, yukkysaito and a team as code owners November 18, 2022 02:58
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022 •
edited
Loading

Codecov Report

Base: 10.47% // Head: 10.44% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2aa5967) compared to base (523b77f).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 2aa5967 differs from pull request most recent head 17a2e63. Consider uploading reports for the commit 17a2e63 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   10.47%   10.44%   -0.03%     
==========================================
  Files        1252     1252              
  Lines       91075    91321     +246     
  Branches    20919    20919              
==========================================
- Hits         9538     9537       -1     
- Misses      71546    71792     +246     
- Partials     9991     9992       +1
Flag Coverage Δ *Carryforward flag
differential 14.83% <0.00%> (?)
total 10.44% <0.00%> (-0.01%) ⬇️ Carriedforward from 523b77f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ssor/concatenate_data/concatenate_data_nodelet.hpp 0.00% <ø> (ø)
.../src/concatenate_data/concatenate_data_nodelet.cpp 0.00% <0.00%> (ø)
...or/src/crop_box_filter/crop_box_filter_nodelet.cpp 0.00% <ø> (ø)
.../src/distortion_corrector/distortion_corrector.cpp 0.00% <0.00%> (ø)
.../pointcloud_preprocessor/src/utility/utilities.cpp 0.00% <0.00%> (ø)
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

yukkysaito
yukkysaito approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx
Copy link
Contributor

xmfcx commented Nov 18, 2022

What is the reason for reverting this change?

@xmfcx
Copy link
Contributor

xmfcx commented Nov 18, 2022

I see it's for #2306

@xmfcx
Copy link
Contributor

xmfcx commented Nov 18, 2022

I think it's ok, it's better to add point_cloud_msg_wrapper feature once we finalize the point types architecture in here and allow different point types too.

@miursh miursh changed the title Revert "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper" revert: "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper" Nov 21, 2022
@miursh miursh enabled auto-merge (squash) November 21, 2022 01:14
@miursh miursh merged commit 11ff8ef into main Nov 21, 2022
@miursh miursh deleted the revert-1276-point-cloud-msg-wrapper-pointcloud-preprocessor branch November 21, 2022 07:48
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Nov 22, 2022
Merged
@miursh miursh mentioned this pull request Nov 22, 2022
Closed
3 tasks
This was referenced Nov 22, 2022
Closed
Closed
Closed
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
@miursh @HansRobo
revert: "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper" (a…
a894a54 
…utowarefoundation#2317)

Revert "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper (autowarefoundation#1276)"

This reverts commit ef7dcda.

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
@miursh @kminoda
revert: "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper" (a…
76eae06 
…utowarefoundation#2317)

Revert "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper (autowarefoundation#1276)"

This reverts commit ef7dcda.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
@miursh @YoshiRi
revert: "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper" (a…
871024d 
…utowarefoundation#2317)

Revert "feat(pointcloud_preprocessor): use point_cloud_msg_wrapper (autowarefoundation#1276)"

This reverts commit ef7dcda.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@amc-nu amc-nu Awaiting requested review from amc-nu

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miursh @xmfcx @yukkysaito