Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): add fail-safe api #2295

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Nov 15, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Add fail-safe API.
https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/ad-api/list/api/fail_safe/

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Nov 15, 2022
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) document component:system System design and integration. (auto-assigned) labels Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 10.50% // Head: 11.04% // Increases project coverage by +0.53% 🎉

Coverage data is based on head (bd72e33) compared to base (0a56b56).
Patch coverage: 24.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
+ Coverage   10.50%   11.04%   +0.53%     
==========================================
  Files        1248     1219      -29     
  Lines       90608    87256    -3352     
  Branches    20728    20833     +105     
==========================================
+ Hits         9517     9634     +117     
+ Misses      70996    67434    -3562     
- Partials    10095    10188      +93     
Flag Coverage Δ *Carryforward flag
differential 6.74% <24.73%> (?)
total 11.06% <ø> (+0.59%) ⬆️ Carriedforward from 8fbc79d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
system/default_ad_api/src/operation_mode.cpp 24.09% <24.09%> (ø)
system/default_ad_api/src/fail_safe.cpp 30.00% <30.00%> (ø)
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)
.../obstacle_avoidance_planner/src/utils/cv_utils.cpp 0.00% <0.00%> (ø)
...stacle_avoidance_planner/src/utils/debug_utils.cpp 0.00% <0.00%> (ø)
...vior_velocity_planner/include/utilization/util.hpp 0.00% <0.00%> (ø)
...based_prediction/src/map_based_prediction_node.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/run_out/manager.cpp 0.00% <0.00%> (ø)
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shmpwk shmpwk removed the document label Nov 16, 2022
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code!

@isamu-takagi isamu-takagi merged commit 04e983a into autowarefoundation:main Nov 22, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/fail-safe branch November 22, 2022 03:52
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants