Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): revise some content about avoidance in .md #2261

Merged
merged 3 commits into from
Jan 22, 2023
Merged

fix(behavior_path_planner): revise some content about avoidance in .md #2261

merged 3 commits into from
Jan 22, 2023

Conversation

shulanbushangshu
Copy link
Contributor

@shulanbushangshu shulanbushangshu commented Nov 10, 2022

Description

This PR revises some content about avoidance in README.md and behavior_path_planner_avoidance-design.md

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: jack.song <jack.song@autocore.ai>
@taikitanaka3 taikitanaka3 changed the title Fix behavior path doc doc: fix behavior path doc Nov 10, 2022
@shulanbushangshu shulanbushangshu changed the title doc: fix behavior path doc fix(behavior_path_planner): revises some content about avoidance in .md Nov 10, 2022
@shulanbushangshu shulanbushangshu changed the title fix(behavior_path_planner): revises some content about avoidance in .md fix(behavior_path_planner): revise some content about avoidance in .md Nov 10, 2022
@taikitanaka3 taikitanaka3 added the type:documentation Creating or refining documentation. (auto-assigned) label Nov 10, 2022
@taikitanaka3
Copy link
Contributor

@shulanbushangshu
you need doc: ~ for document PR

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 11.12% // Head: 11.07% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (9e28cc9) compared to base (d3768c4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   11.12%   11.07%   -0.06%     
==========================================
  Files        1200     1200              
  Lines       86198    86609     +411     
  Branches    20793    21037     +244     
==========================================
  Hits         9593     9593              
- Misses      66479    66873     +394     
- Partials    10126    10143      +17     
Flag Coverage Δ *Carryforward flag
differential 3.59% <ø> (?)
total 11.10% <ø> (ø) Carriedforward from d3768c4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/behavior_path_planner/src/utilities.cpp 3.42% <0.00%> (-0.42%) ⬇️
...ner/src/scene_module/pull_over/shift_pull_over.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. LGTM 👍

@stale
Copy link

stale bot commented Jan 21, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added status:stale Inactive or outdated issues. (auto-assigned) and removed status:stale Inactive or outdated issues. (auto-assigned) labels Jan 21, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 22, 2023
@satoshi-ota satoshi-ota merged commit 90b8617 into autowarefoundation:main Jan 22, 2023
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Jan 30, 2023
autowarefoundation#2261)

* fix-behavior-path-doc

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix-behavior-path-doc

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: jack.song <jack.song@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lexavtanke pushed a commit to lexavtanke/autoware.universe that referenced this pull request Jan 31, 2023
autowarefoundation#2261)

* fix-behavior-path-doc

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix-behavior-path-doc

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: jack.song <jack.song@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Feb 3, 2023
autowarefoundation#2261)

* fix-behavior-path-doc

Signed-off-by: jack.song <jack.song@autocore.ai>

* fix-behavior-path-doc

Signed-off-by: jack.song <jack.song@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: jack.song <jack.song@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants