Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap #2250

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 8, 2022

Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp

Description

Additional fix for these:

Tests performed

Checked that the behavior_velocity_planner does not die on the evaluator.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ineFromMap

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 11.13% // Head: 11.13% // No change to project coverage 👍

Coverage data is based on head (d3bb082) compared to base (2058c7d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2250   +/-   ##
=======================================
  Coverage   11.13%   11.13%           
=======================================
  Files        1200     1200           
  Lines       86222    86222           
  Branches    20802    20802           
=======================================
  Hits         9605     9605           
  Misses      66485    66485           
  Partials    10132    10132           
Flag Coverage Δ *Carryforward flag
differential 4.23% <0.00%> (?)
total 11.11% <0.00%> (ø) Carriedforward from 565cda0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin
Copy link
Contributor Author

soblin commented Nov 9, 2022

@TakaHoribe I reflected your advice and just opened this PR.

@TakaHoribe TakaHoribe self-requested a review November 9, 2022 09:47
@TakaHoribe TakaHoribe enabled auto-merge (squash) November 9, 2022 09:47
@TakaHoribe TakaHoribe merged commit 9ccc24f into autowarefoundation:main Nov 9, 2022
@soblin soblin deleted the fix/intersection-interval branch November 9, 2022 10:13
soblin added a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2022
…ineFromMap (autowarefoundation#2250)

* fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* avoid subtraction and use < instead of <=

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…ineFromMap (autowarefoundation#2250)

* fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* avoid subtraction and use < instead of <=

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
soblin added a commit to soblin/autoware.universe that referenced this pull request Dec 22, 2022
…ineFromMap (autowarefoundation#2250)

* fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* avoid subtraction and use < instead of <=

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…ineFromMap (autowarefoundation#2250)

* fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* avoid subtraction and use < instead of <=

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants