-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap #2250
fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap #2250
Conversation
…ineFromMap Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Codecov ReportBase: 11.13% // Head: 11.13% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2250 +/- ##
=======================================
Coverage 11.13% 11.13%
=======================================
Files 1200 1200
Lines 86222 86222
Branches 20802 20802
=======================================
Hits 9605 9605
Misses 66485 66485
Partials 10132 10132
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
planning/behavior_velocity_planner/src/scene_module/intersection/util.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@TakaHoribe I reflected your advice and just opened this PR. |
…ineFromMap (autowarefoundation#2250) * fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * avoid subtraction and use < instead of <= Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ineFromMap (autowarefoundation#2250) * fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * avoid subtraction and use < instead of <= Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ineFromMap (autowarefoundation#2250) * fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * avoid subtraction and use < instead of <= Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ineFromMap (autowarefoundation#2250) * fix(behavior_velocity_planner): fix intersection interval in getStopLineFromMap Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * avoid subtraction and use < instead of <= Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp
Description
Additional fix for these:
Tests performed
Checked that the behavior_velocity_planner does not die on the evaluator.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.