-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ndt_scan_matcher): modularize map_callback #2249
refactor(ndt_scan_matcher): modularize map_callback #2249
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportBase: 11.13% // Head: 11.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
========================================
Coverage 11.13% 11.14%
========================================
Files 1200 1201 +1
Lines 86211 86335 +124
Branches 20802 20787 -15
========================================
+ Hits 9601 9620 +19
- Misses 66478 66590 +112
+ Partials 10132 10125 -7
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…ithub.com:kminoda/autoware.universe into refactor/ndt_scan_matcher/modularize_map_callback
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code seems to be fine.
I added just one comment, please check it out.
localization/ndt_scan_matcher/include/ndt_scan_matcher/map_module.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on#2249) * still work in progress Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * ptr_ptr yameru Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove unnecessary newline Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert launch setting Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * reverted debugging line Signed-off-by: kminoda <koji.minoda@tier4.jp> * pre-commit Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove format inclusion Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…on#2249) * still work in progress Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * ptr_ptr yameru Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove unnecessary newline Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert launch setting Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * reverted debugging line Signed-off-by: kminoda <koji.minoda@tier4.jp> * pre-commit Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove format inclusion Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
Aiming at integrating dynamic map loading feature in ndt_scan_matcher smoothly, I would like to modularize ndt_scan_matcher into the following modules:
As a first step, I would like to modularize callback_map_points.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.