Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): modularize map_callback #2249

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 8, 2022

Description

Aiming at integrating dynamic map loading feature in ndt_scan_matcher smoothly, I would like to modularize ndt_scan_matcher into the following modules:

As a first step, I would like to modularize callback_map_points.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda self-assigned this Nov 8, 2022
@kminoda kminoda added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 11.13% // Head: 11.14% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d7e4c7a) compared to base (ed6b5c8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2249    +/-   ##
========================================
  Coverage   11.13%   11.14%            
========================================
  Files        1200     1201     +1     
  Lines       86211    86335   +124     
  Branches    20802    20787    -15     
========================================
+ Hits         9601     9620    +19     
- Misses      66478    66590   +112     
+ Partials    10132    10125     -7     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.13% <ø> (+0.02%) ⬆️ Carriedforward from 179f692

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
localization/ndt_scan_matcher/src/map_module.cpp 0.00% <0.00%> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <0.00%> (ø)
...rajectory_follower/pid_longitudinal_controller.hpp 0.00% <0.00%> (-28.58%) ⬇️
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
.../trajectory_follower_nodes/src/controller_node.cpp 42.02% <0.00%> (ø)
...ctory_follower/include/trajectory_follower/mpc.hpp 46.66% <0.00%> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
...pi_helpers/ad_api_adaptors/src/routing_adaptor.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/stop_line/scene.cpp 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kminoda and others added 8 commits November 9, 2022 09:46
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…ithub.com:kminoda/autoware.universe into refactor/ndt_scan_matcher/modularize_map_callback
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code seems to be fine.
I added just one comment, please check it out.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 2a48d14 into autowarefoundation:main Nov 9, 2022
@kminoda kminoda deleted the refactor/ndt_scan_matcher/modularize_map_callback branch November 21, 2022 04:37
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…on#2249)

* still work in progress

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ptr_ptr yameru

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove unnecessary newline

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert launch setting

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* reverted debugging line

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove format inclusion

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…on#2249)

* still work in progress

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ptr_ptr yameru

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove unnecessary newline

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert launch setting

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* reverted debugging line

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove format inclusion

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants