refactor(vehicle_constants_manager)!: remove package #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
|
@xmfcx Can I remove this package? |
|
Sure, I've created this package in Autoware.Auto as a mirror of |
xmfcx
approved these changes
Nov 7, 2022
|
@kenji-miyake why is this job giving following error? It seems ok to me 🤔 |
takayuki5168
changed the title
|
Oh it was just the space character before the colon 😮 |
|
@xmfcx Thank you. Regarding failed job, there is unnecessary space since we cannot put "!" with |
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…ion#2232) refactor(vehicle_constants_manager)! : remove package Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…ion#2232) refactor(vehicle_constants_manager)! : remove package Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
Since we have vehicle_info_util widely used in autwoare.universe, the almost same package (vehicle_constants_manager) is not needed.
https://github.com/autowarefoundation/autoware.universe/tree/main/vehicle/vehicle_info_util/
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.