Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): modularize callback_sensor_points and some related functions #2224

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 7, 2022

Description

Aiming at integrating dynamic map loading feature in ndt_scan_matcher smoothly, I would like to modularize ndt_scan_matcher into the following modules:

  • module that execute NDT scan matching (ndt_scan_matching_module) (This PR)
  • module that load pointcloud map (map_module)
  • module that execute the pose initialization (initial_pose_module)

As a third step, I would like to modularize callback_sensor_points and some related functions as an individual module.

Previous PRs:

Some concerns:

  • Is ndt_ptr_ptr_ the best practice to share the ndt_ptr_ among several objects?

(A side note: this would be the largest PR in terms of the modified lines by far until the dynamic map loading integration 🔥 )

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda and others added 3 commits November 7, 2022 17:56
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda assigned kminoda and unassigned kminoda Nov 7, 2022
@kminoda kminoda added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 11.09% // Head: 11.05% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (7dea7e3) compared to base (c5e7246).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 7dea7e3 differs from pull request most recent head 2b777d7. Consider uploading reports for the commit 2b777d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2224      +/-   ##
==========================================
- Coverage   11.09%   11.05%   -0.05%     
==========================================
  Files        1201     1203       +2     
  Lines       86193    86530     +337     
  Branches    20704    20706       +2     
==========================================
  Hits         9564     9564              
- Misses      66670    66874     +204     
- Partials     9959    10092     +133     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.06% <0.00%> (-0.01%) ⬇️ Carriedforward from f7bc465

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/ndt_scan_matcher/ndt_scan_matcher_core.hpp 0.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <0.00%> (ø)
.../ndt_scan_matcher/src/ndt_scan_matching_module.cpp 0.00% <0.00%> (ø)
common/osqp_interface/src/osqp_interface.cpp 33.65% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
control/trajectory_follower/src/mpc_utils.cpp 58.25% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.41% <0.00%> (ø)
common/motion_utils/src/marker/marker_helper.cpp 0.00% <0.00%> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
... and 92 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kminoda and others added 4 commits November 8, 2022 09:35
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Copy link
Contributor Author

kminoda commented Nov 14, 2022

Close this PR as this is not necessary for now.

@kminoda kminoda closed this Nov 14, 2022
@kminoda kminoda deleted the refactor/ndt_scan_matcher/modularize_cb_sensor branch August 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant