Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_collision_checker): add some debugs, change QoS #2191

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Nov 1, 2022

Signed-off-by: Berkay Karaman berkay@leodrive.ai

Description

Issue: #2143
Related: #2153

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
@brkay54 brkay54 self-assigned this Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 10.84% // Head: 10.82% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a88172f) compared to base (730848d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2191      +/-   ##
==========================================
- Coverage   10.84%   10.82%   -0.02%     
==========================================
  Files        1179     1179              
  Lines       84840    84938      +98     
  Branches    19982    20043      +61     
==========================================
+ Hits         9197     9198       +1     
- Misses      65909    65996      +87     
- Partials     9734     9744      +10     
Flag Coverage Δ *Carryforward flag
differential 7.74% <0.00%> (?)
total 10.81% <0.00%> (ø) Carriedforward from 730848d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lision_checker_node/obstacle_collision_checker.cpp 7.07% <0.00%> (-0.46%) ⬇️
...n_checker_node/obstacle_collision_checker_node.cpp 0.86% <0.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you.

@brkay54 brkay54 merged commit ff1af93 into autowarefoundation:main Nov 1, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…towarefoundation#2191)

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>

Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Co-authored-by: Berkay Karaman <berkay@leodrive.ai>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@brkay54 brkay54 deleted the refactor-occ branch April 27, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants