refactor(intersection): code clean #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…elets Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
refactor/intersection
branch
from
41bb84b
to
7ab8a28
Compare
Codecov ReportBase: 10.35% // Head: 10.31% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2071 +/- ##
==========================================
- Coverage 10.35% 10.31% -0.04%
==========================================
Files 1175 1175
Lines 84044 84344 +300
Branches 19590 19892 +302
==========================================
Hits 8704 8704
- Misses 65831 66108 +277
- Partials 9509 9532 +23
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
force-pushed
the
refactor/intersection
branch
from
4d1eb55
to
5d3f57b
Compare
soblin
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
satoshi-ota,
shmpwk,
taikitanaka3,
TomohitoAndo,
tkimura4 and
purewater0901
as code owners
|
@kyoichi-sugahara Can you have a look the changes and approve this PR? |
3 tasks
scepter914
pushed a commit
to scepter914/autoware.universe
that referenced
this pull request
Nov 1, 2022
* avoid lanelet <-> id as much as possible * return detection_lanelets and conflicting_lanelets in getObjectiveLanelets Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: scepter914 <scepter914@gmail.com>
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
Dec 22, 2022
* avoid lanelet <-> id as much as possible * return detection_lanelets and conflicting_lanelets in getObjectiveLanelets Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the functionality is getting stable, this module can be refactored.
cc: @veqcc
list of refactored points (improvement of computation time will be done in next PR)
constvector<lanelet id>, and usevector<lanelet>Tests performed
Checked in psim
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.