Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(heatmap_visualizer): refactor replacing util library #2063

Merged

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Oct 13, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

Replace util library in heatmap_visualizer

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 10.36% // Head: 10.36% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1e24b2d) compared to base (0af97ea).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   10.36%   10.36%   -0.01%     
==========================================
  Files        1176     1176              
  Lines       84010    84028      +18     
  Branches    19563    19563              
==========================================
  Hits         8707     8707              
- Misses      65803    65821      +18     
  Partials     9500     9500              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.34% <0.00%> (ø) Carriedforward from 0af97ea

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...heatmap_visualizer/src/heatmap_visualizer_node.cpp 0.00% <0.00%> (ø)
perception/heatmap_visualizer/src/utils.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 enabled auto-merge (squash) October 15, 2022 13:53
@scepter914 scepter914 merged commit 4a0b1c3 into autowarefoundation:main Oct 15, 2022
scepter914 added a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
…refoundation#2063)

* refactor(heatmap_visualizer): refactor replacing util library

Signed-off-by: scepter914 <scepter914@gmail.com>

* delete unused using

Signed-off-by: scepter914 <scepter914@gmail.com>

* apply pre-commit

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 deleted the refactor/heatmap_visualizer branch April 19, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants