Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: missing topic info duration 1000 -> 5000 #2056

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 13, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

Currently, duration of debug print for missing topics is too high.
Therefore, I made them low (1000 -> 5000).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

Let me know if 5000 is too low.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5000 is enough for me when testing it on the real environment.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 10.44% // Head: 10.16% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (a4297ef) compared to base (b5d4e05).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
- Coverage   10.44%   10.16%   -0.28%     
==========================================
  Files        1163     1164       +1     
  Lines       83164    85617    +2453     
  Branches    19546    21305    +1759     
==========================================
+ Hits         8686     8703      +17     
- Misses      64974    67240    +2266     
- Partials     9504     9674     +170     
Flag Coverage Δ *Carryforward flag
differential 4.12% <0.00%> (?)
total 10.42% <ø> (ø) Carriedforward from b5d4e05

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...analysis/src/control_performance_analysis_node.cpp 0.00% <ø> (ø)
...troller/src/joy_controller/joy_controller_node.cpp 0.00% <ø> (ø)
...rture_checker_node/lane_departure_checker_node.cpp 0.41% <ø> (ø)
...n_checker_node/obstacle_collision_checker_node.cpp 0.72% <ø> (ø)
.../trajectory_follower_nodes/src/controller_node.cpp 42.02% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.38% <0.00%> (+0.12%) ⬆️
...y_planner/src/scene_module/traffic_light/scene.cpp 0.00% <ø> (ø)
planning/obstacle_stop_planner/src/node.cpp 0.00% <ø> (ø)
planning/surround_obstacle_checker/src/node.cpp 0.00% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 52c7ce3 into autowarefoundation:main Oct 13, 2022
@takayuki5168 takayuki5168 deleted the chore/missing-topic-duration branch October 13, 2022 03:12
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants