Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_debug_rviz_plugin): pie chart with float32 multi array stamped #2055

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Oct 12, 2022

Description

pie chart from tier4_debug_msgs::msg::Float32MultiArrayStamped based on jsk_rviz_plugins (BSD license)

image

This plugin is useful to visualize the data of debug messages like obstacle_cruise_planner's, longitudinal_controller's, lateral_controller's, etc.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…rayStamped

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 changed the title Feat/pie chart with float32 multi array feat(tier4_debug_rviz_plugin): pie chart with float32 multi array stamped Oct 12, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review October 12, 2022 15:09
@takayuki5168 takayuki5168 added the type:documentation Creating or refining documentation. (auto-assigned) label Oct 12, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@@ -0,0 +1,193 @@
// Copyright (c) 2014, JSK Lab
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takayuki5168
Copy link
Contributor Author

@yukkysaito @tkimura4 Could you review this PR.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 10.44% // Head: 10.39% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (29e6abb) compared to base (b5d4e05).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
- Coverage   10.44%   10.39%   -0.05%     
==========================================
  Files        1163     1166       +3     
  Lines       83164    83530     +366     
  Branches    19546    19546              
==========================================
  Hits         8686     8686              
- Misses      64974    65340     +366     
  Partials     9504     9504              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.42% <ø> (ø) Carriedforward from b5d4e05

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...z_plugin/float32_multi_array_stamped_pie_chart.hpp 0.00% <0.00%> (ø)
...ugin/src/float32_multi_array_stamped_pie_chart.cpp 0.00% <0.00%> (ø)
.../tier4_debug_rviz_plugin/src/jsk_overlay_utils.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/pie-chart-with-float32-multi-array branch from 5ed38fd to 25805d1 Compare October 13, 2022 03:26
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 96bc202 into autowarefoundation:main Oct 14, 2022
@takayuki5168 takayuki5168 deleted the feat/pie-chart-with-float32-multi-array branch October 14, 2022 02:14
scepter914 pushed a commit to scepter914/autoware.universe that referenced this pull request Nov 1, 2022
…mped (autowarefoundation#2055)

* feat(tier4_debug_rviz_plugin): add ros2 pie chart with Float32MultiArrayStamped

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update README.md

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix typo

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fixed license

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* removed unnecessary include

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants