Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ndt_scan_matcher): isolate implementation type to ndt #2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Oct 5, 2022

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

I propose to move the NDTImplementType definition from ndt_scan_matcher to ndt package.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda marked this pull request as ready for review October 5, 2022 08:36
@kminoda kminoda self-assigned this Oct 5, 2022
kminoda and others added 3 commits October 5, 2022 17:40
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 10.36% // Head: 10.32% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (352e3ff) compared to base (87f2322).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
- Coverage   10.36%   10.32%   -0.04%     
==========================================
  Files        1160     1161       +1     
  Lines       82517    82812     +295     
  Branches    19280    19280              
==========================================
  Hits         8550     8550              
- Misses      64707    65002     +295     
  Partials     9260     9260              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.34% <0.00%> (ø) Carriedforward from 8a68002

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
localization/ndt/include/ndt/impl/omp.hpp 0.00% <0.00%> (ø)
localization/ndt/include/ndt/impl/pcl_generic.hpp 0.00% <0.00%> (ø)
localization/ndt/include/ndt/impl/pcl_modified.hpp 0.00% <0.00%> (ø)
localization/ndt/include/ndt/omp.hpp 0.00% <ø> (ø)
localization/ndt/include/ndt/pcl_generic.hpp 0.00% <ø> (ø)
localization/ndt/include/ndt/pcl_modified.hpp 0.00% <ø> (ø)
...include/ndt_scan_matcher/ndt_scan_matcher_core.hpp 0.00% <ø> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda closed this Oct 7, 2022
@kminoda kminoda deleted the refactor/ndt_scan_matcher/isolate_implementation_type branch November 30, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant