Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_cruise_planner): ignore behind obstacles #1894

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Sep 16, 2022

Description

The current implementation does not adequately filter backward vehicles, and reacts to backward vehicles in cases such as
following image.
image

I fixed this by enhancing filtering for backward vehicles out of trajectory.

Related links

Tests performed

With this PR, backward vehicles are ignored properly.
image

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 10.44% // Head: 10.41% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (726d4c4) compared to base (23e261c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
- Coverage   10.44%   10.41%   -0.04%     
==========================================
  Files        1233     1233              
  Lines       88027    88323     +296     
  Branches    20501    20501              
==========================================
  Hits         9197     9197              
- Misses      69319    69615     +296     
  Partials     9511     9511              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.43% <0.00%> (ø) Carriedforward from 23e261c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit 8c0a11f into autowarefoundation:main Sep 16, 2022
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2022
…ion#1894 (#131)

* fix(obstacle_cruise_planner): ignore behind obstacles

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update isFrontCollideObstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 deleted the fix/cruise_planner_behind_obstacle branch September 16, 2022 08:08
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Sep 20, 2022
…ion#1894 (#131)

* fix(obstacle_cruise_planner): ignore behind obstacles

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update isFrontCollideObstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Sep 27, 2022
…tion#1894)

* fix(obstacle_cruise_planner): ignore behind obstacles

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix invalid access

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update isFrontCollideObstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: Yoshi Ri <yoshi.ri@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…tion#1894)

* fix(obstacle_cruise_planner): ignore behind obstacles

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix invalid access

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update isFrontCollideObstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…tion#1894)

* fix(obstacle_cruise_planner): ignore behind obstacles

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix invalid access

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update isFrontCollideObstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…tion#1894)

* fix(obstacle_cruise_planner): ignore behind obstacles

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix invalid access

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update isFrontCollideObstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…tion#1894)

* fix(obstacle_cruise_planner): ignore behind obstacles

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix invalid access

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update isFrontCollideObstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants