fix(crosswalk_traffic_light_estimator): fix invalid access

[tkimura4]

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

(crosswalk_traffic_light_estimator)
Currently, in the for-loop of last_detect_color_, last_detect_color_.erase() is called.
It causes invalid access and the crosswalk_traffic_light_estimator node dies frequently now.
I fixed it.

Related links

Tests performed

I confirmed the improvement with the rosbag.
(I'm sorry but I can't provide the rosbag here because it contains camera images including personal data.)

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[satoshi-ota]

LGTM 👍
Thank you for your bug fix 🙏
Could you fix semantics error (CI/CD) ?

[codecov]

Codecov Report

Merging #1825 (89c9d02) into main (34bf3ba) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   10.46%   10.46%   -0.01%     
==========================================
  Files        1221     1221              
  Lines       87557    87598      +41     
  Branches    20489    20489              
==========================================
  Hits         9165     9165              
- Misses      69039    69080      +41     
  Partials     9353     9353              

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	10.45% <0.00%> (ø)		Carriedforward from 34bf3ba

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ion/crosswalk_traffic_light_estimator/src/node.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[tkimura4]

Could you fix semantics error (CI/CD) ?

Thank you! I fixed.