Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(run_out): refactor debug markers #1811

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Sep 8, 2022

Description

Refactor for debug marker of run out module.
There are no effects to the actual behavior.

  • modified the topic name
  • organized the namespace
  • removed unnecessary marker
  • fix the height of the marker to see in 3D
simplescreenrecorder-2022-09-08_18.35.41.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo changed the title Refactor run out debug marker refactor(run_out): refactor for debug marker Sep 8, 2022
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo changed the title refactor(run_out): refactor for debug marker refactor(run_out): refactor debug markers Sep 8, 2022
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1811 (849c18c) into main (8c198af) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   10.74%   10.70%   -0.04%     
==========================================
  Files        1148     1148              
  Lines       84761    85032     +271     
  Branches    20451    20620     +169     
==========================================
  Hits         9106     9106              
- Misses      66301    66559     +258     
- Partials     9354     9367      +13     
Flag Coverage Δ *Carryforward flag
differential 4.24% <0.00%> (?)
total 10.72% <0.00%> (ø) Carriedforward from 8c198af

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_planner/include/scene_module/run_out/debug.hpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/debug.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit cd19660 into autowarefoundation:main Sep 12, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
* refactor(run_out): change topic for debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused variables

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: set height of debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify the size of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: change the name of debug texts

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: fix the height of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused function

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* refactor(run_out): change topic for debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused variables

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: set height of debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify the size of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: change the name of debug texts

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: fix the height of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused function

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* refactor(run_out): change topic for debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused variables

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: set height of debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify the size of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: change the name of debug texts

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: fix the height of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused function

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
* refactor(run_out): change topic for debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused variables

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: set height of debug polygons

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: modify the size of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: change the name of debug texts

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: fix the height of debug points

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unused function

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants