Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): lane change set minimum prepare default #1778

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Sep 5, 2022

Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp

Description

Departure from private lane failed due to lane change parameters and slight bug.

Related links

tier4/autoware_launch#465

Tests performed

UC-F-10-00002_PSim_1_case1_cmn:1 scenario file is needed.
tier4/autoware_launch#465 is needed.
The run scenario test.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4
Copy link
Contributor Author

@takayuki5168, @TakaHoribe, @rej55
I've tested the scenario locally, and it seems to fix the issue.
But let me re-do a few test in Evaluator

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1778 (6414b2f) into main (728875e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
- Coverage   10.39%   10.39%   -0.01%     
==========================================
  Files        1218     1218              
  Lines       87391    87392       +1     
  Branches    20228    20229       +1     
==========================================
  Hits         9083     9083              
- Misses      68856    68857       +1     
  Partials     9452     9452              
Flag Coverage Δ *Carryforward flag
differential 1.28% <ø> (?)
total 10.37% <0.00%> (ø) Carriedforward from 9835527

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as draft September 5, 2022 05:28
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@stale
Copy link

stale bot commented Nov 4, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 4, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix/lane-change-evaluator-issue branch December 14, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant