Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id #1735

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 31, 2022

Description

Added velocity text visualizer to path_with_lane_id of tier4_planning_rviz_plugin.

Screenshot from 2022-08-31 12-24-52

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 changed the title feat(tier4_planning_rviz_plugin): add velocity_test to path_with_lane_id feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id Aug 31, 2022
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 force-pushed the feat/path_with_lane_id_velocity_text branch from 3001c4d to d31f8e2 Compare August 31, 2022 03:37
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1735 (98131ee) into main (f1a8851) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1735   +/-   ##
=======================================
  Coverage   10.28%   10.29%           
=======================================
  Files        1204     1204           
  Lines       86808    86731   -77     
  Branches    20046    20046           
=======================================
- Hits         8931     8930    -1     
+ Misses      68718    68643   -75     
+ Partials     9159     9158    -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.29% <0.00%> (+0.01%) ⬆️ Carriedforward from d31f8e2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ning_rviz_plugin/src/path_with_lane_id/display.cpp 0.00% <0.00%> (ø)
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/calibrator.hpp 0.00% <0.00%> (ø)
...eption/tensorrt_yolo/lib/src/plugins/yolo_layer.cu 0.00% <0.00%> (ø)
...ption/tensorrt_yolo/lib/src/plugins/nms_plugin.cpp 0.00% <0.00%> (ø)
...tion/lidar_centerpoint/lib/network/network_trt.cpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit eae1714 into autowarefoundation:main Aug 31, 2022
@kosuke55 kosuke55 deleted the feat/path_with_lane_id_velocity_text branch August 31, 2022 05:27
TakaHoribe pushed a commit to TakaHoribe/autoware.universe that referenced this pull request Sep 5, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 14, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2023
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2023
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2023
…_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 24, 2023
* feat(behavior_path_palnner): update geometric parallel parking for pull_out module (autowarefoundation#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): update pull out (autowarefoundation#1438)

* feat(behavior_path_planner): update pull out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* refactor(behavior_path_planner): rename pull_out params

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update from review

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use debug_data

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* enable back

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* move PlannerType

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix debug marker

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add seach priority

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* change before_pull_out_straight_distance to 0.0

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(motion_utils): add isDrivingForward function (autowarefoundation#1360)

* feat(motion_utils: add isDrivingForward function

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* implemented isDrivingForward

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* use isDrivingForward in each module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_autoware_utils): add setter/getter of longitudinal velocity

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* added test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(tier4_planning_rviz_plugin): support backward driving in path/traj plugin (autowarefoundation#1335)

* fix(tier4_planning_rviz_plugin): support backward driving in path_with_lane_id/path/trajectory plugin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add utils.hpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update pull out default th_stopped_time

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants