Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): remove the IDX struct and replace to the actual numbers #1732

Closed
wants to merge 2 commits into from

Conversation

IshitaTakeshi
Copy link
Contributor

@IshitaTakeshi IshitaTakeshi commented Aug 30, 2022

Description

The IDX struct doesn't really improve the readability, so replaced it with actual numbers.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1732 (11c43a8) into main (ae833f3) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   10.28%   10.29%   +0.01%     
==========================================
  Files        1205     1203       -2     
  Lines       86798    86662     -136     
  Branches    20067    20067              
==========================================
  Hits         8926     8926              
+ Misses      68712    68576     -136     
  Partials     9160     9160              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.28% <0.00%> (+0.01%) ⬆️ Carriedforward from 8f7898d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/calibrator.hpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/cuda_utils.hpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
...on/lidar_apollo_instance_segmentation/src/node.cpp 0.00% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IshitaTakeshi IshitaTakeshi changed the title Remove the IDX struct and replace to the actual numbers refactor(ekf_localizer): remove the IDX struct and replace to the actual numbers Aug 30, 2022
@wep21 wep21 requested a review from TakaHoribe August 30, 2022 17:50
@YamatoAndo YamatoAndo added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Aug 30, 2022
@YamatoAndo
Copy link
Contributor

I think the code using the IDX is easier to understand which element it refers to.

@IshitaTakeshi
Copy link
Contributor Author

I think it is better to this one after cleaning other parts of the code so I close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants