Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_smoother): delete unnecessary linear interpolation #1729

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 30, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Delete linear interpolation file from motion velocity smoother and use interpolation function from interpolation directory. It works well in the Planning Simulator.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1729 (2ef5e39) into main (fbcfee1) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
- Coverage   10.24%   10.17%   -0.08%     
==========================================
  Files        1204     1204              
  Lines       86772    88003    +1231     
  Branches    20054    20824     +770     
==========================================
+ Hits         8894     8957      +63     
- Misses      68616    69672    +1056     
- Partials     9262     9374     +112     
Flag Coverage Δ *Carryforward flag
differential 3.88% <0.00%> (?)
total 10.23% <0.00%> (ø) Carriedforward from fbcfee1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...k_constrained_smoother/velocity_planning_utils.cpp 0.00% <0.00%> (ø)
.../motion_velocity_smoother/src/trajectory_utils.cpp 4.12% <0.00%> (+0.76%) ⬆️
...r_velocity_planner/test/src/test_arc_lane_util.cpp 37.63% <0.00%> (-3.11%) ⬇️
...behavior_velocity_planner/src/utilization/util.cpp 11.00% <0.00%> (-1.46%) ⬇️
...vior_velocity_planner/include/utilization/util.hpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/stop_line/scene.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/debug.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <0.00%> (ø)
...y_planner/include/utilization/trajectory_utils.hpp 0.00% <0.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3
Copy link
Contributor

@purewater0901
Can you add unit test to make sure this change keeps same behavior for edge case?

@purewater0901
Copy link
Contributor Author

@taikitanaka3 This PR just deletes the unnecessary files, and I did not add new functions. So I think we don't need to add unit tests for this PR.

@taikitanaka3
Copy link
Contributor

@purewater0901
So you make sure this is refactoring PR and there is no difference between interpolation method?

@purewater0901
Copy link
Contributor Author

@taikitanaka3 Yes

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 5c64f8a into autowarefoundation:main Aug 31, 2022
@purewater0901 purewater0901 deleted the feat/delete-interpolation branch August 31, 2022 01:20
TakaHoribe pushed a commit to TakaHoribe/autoware.universe that referenced this pull request Sep 5, 2022
…on (autowarefoundation#1729)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…on (autowarefoundation#1729)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…on (autowarefoundation#1729)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…on (autowarefoundation#1729)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…on (autowarefoundation#1729)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…on (autowarefoundation#1729)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants