fix(mission_planner, route_handler): enable loop detection of route

[tkimura4]

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

In the current implementation, isRouteLooped() always returns false because one primitives has only one id.
Duplicate check of lane_id must be done for the entire segments. I fixed it.

Related links

Tests performed

I confirmed that the following error occurs and route was not published when I tried to set route with overlapping lanes using check points.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[yukkysaito]

@mitsudome-r -san is added because I think he did it first.

[codecov]

Codecov Report

Merging #1705 (fad7354) into main (73bd233) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
- Coverage   10.42%   10.16%   -0.27%     
==========================================
  Files        1220     1148      -72     
  Lines       87342    77162   -10180     
  Branches    20490    19187    -1303     
==========================================
- Hits         9109     7844    -1265     
+ Misses      68757    60204    -8553     
+ Partials     9476     9114     -362     

Flag	Coverage Δ		*Carryforward flag
differential	2.47% <0.00%> (?)
total	10.31% <0.00%> (-0.11%)	⬇️	Carriedforward from 73bd233

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...sion_planner_lanelet2/mission_planner_lanelet2.cpp	0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp	0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp	0.00% <0.00%> (-71.43%)	⬇️
...c/autoware_ad_api_msgs/msg/route__type_support.cpp	0.00% <0.00%> (-66.67%)	⬇️
...oware_ad_api_msgs/msg/route_data__type_support.cpp	0.00% <0.00%> (-66.67%)	⬇️
...ware_ad_api_msgs/msg/route_state__type_support.cpp	0.00% <0.00%> (-66.67%)	⬇️
...re_ad_api_msgs/msg/route_segment__type_support.cpp	0.00% <0.00%> (-66.67%)	⬇️
..._ad_api_msgs/msg/response_status__type_support.cpp	0.00% <0.00%> (-66.67%)	⬇️
..._ad_api_msgs/msg/route_primitive__type_support.cpp	0.00% <0.00%> (-66.67%)	⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp	0.00% <0.00%> (-66.67%)	⬇️
... and 755 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[TakaHoribe]

LGTM!

[taikitanaka3]

@tkimura4
can you resolve this conflict?

[tkimura4]

@taikitanaka3
resolved! 🐶

[taikitanaka3]

LGTM
I confirmed there is no warning like before this PR