Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interpolation): case query key is same #1657

Closed

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 23, 2022

Description

The way to solve this #1658

  1. allow same query key
    this PR

  2. Do not insert same query key to add "DOUBLE_EPSILON" (= 1e-6 for temporary)

    if (s_in.at(j) < s_out.at(i) + DOUBLE_EPSILON && s_out.at(i) < s_in.at(j + 1)) {

  3. purge resampling points when query is very small enough
    might affect other modules

[component_container_mt-52] terminate called after throwing an instance of 'std::invalid_argument'
[component_container_mt-52]   what():  Either base_keys or query_keys is not sorted.
[ERROR] [component_container_mt-52]: process has died [pid 21779, exit code -6, cmd '/opt/ros/galactic/lib/rclcpp_components/component_container_mt --ros-args -r __node:=behavior_planning_container -r __ns:=/planning/scenario_planning/lane_driving/behavior_planning --params-file /tmp/launch_params_b1m0l4fr'].

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant