Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): enable pull_over backward_parking by default #1653

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 22, 2022

Description

enable pull_over backward_parking by default for checking in scenario tests.

Related links

tier4/autoware_launch#448

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 changed the title feature(behavior_path_planner): enabale pull_over backward_parking by default feature(behavior_path_planner): enable pull_over backward_parking by default Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1653 (d9ea0f3) into main (27f9216) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   10.66%   10.66%           
=======================================
  Files        1108     1108           
  Lines       78748    78748           
  Branches    18640    18640           
=======================================
  Hits         8397     8397           
  Misses      61438    61438           
  Partials     8913     8913           
Flag Coverage Δ *Carryforward flag
differential 0.78% <0.00%> (?)
total 10.64% <0.00%> (ø) Carriedforward from 27f9216

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…ault

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 changed the title feature(behavior_path_planner): enable pull_over backward_parking by default feat(behavior_path_planner): enable pull_over backward_parking by default Aug 23, 2022
@kosuke55
Copy link
Contributor Author

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit ddf071c into autowarefoundation:main Aug 29, 2022
@kosuke55 kosuke55 deleted the feature/enable_back_parking branch August 29, 2022 06:37
TakaHoribe pushed a commit to TakaHoribe/autoware.universe that referenced this pull request Sep 5, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…ault (autowarefoundation#1653)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants